Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: How to handle checks that are in both Theme Check and theme review action? #33

Open
carolinan opened this issue May 28, 2021 · 1 comment
Labels
question Further information is requested

Comments

@carolinan
Copy link
Contributor

Some checks are in both theme check and theme review action.
Are there any benefits with this?

For example, checking if the theme folder includes a screenshot and required files.

@StevenDufresne
Copy link
Contributor

It wasn't intended but since we need a theme to have the basics to start up the environment, or determine which theme type we are testing, we need to ensure a few things are in place. If we are able to run the theme-check without needing an environment (statically), which seems quite possible. We could remove it from the theme review action in the future.

@StevenDufresne StevenDufresne added the question Further information is requested label Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants