Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Intro Area with Heading and Image" pattern as a core pattern #685

Closed
richtabor opened this issue Apr 30, 2024 · 6 comments
Closed

Add "Intro Area with Heading and Image" pattern as a core pattern #685

richtabor opened this issue Apr 30, 2024 · 6 comments

Comments

@richtabor
Copy link
Member

I'd like to add this pattern as a core pattern.

It's a bit more structured than the other section-style patterns, an interesting exploration into seeing how patterns can become more reliant on themes, and less on hard-coded values within the pattern.

Exploring early to help orient the next default WordPress theme.

@ryelle
Copy link
Contributor

ryelle commented Apr 30, 2024

@richtabor Does this need approval from other people? Can you share any relevant discussion? I don't think we have an explicit process for making a pattern "curated," but correct me if I'm wrong 🙂

Once that's cleared up, the process will be to add the core internal keyword, which will mark it as "curated" on the pattern directory and start sending it to WordPress sites. In the past we've also moved these to the wordpressdotorg user, but I don't recall if that was a requirement (it is not, technically).

Does this pattern work with all WP versions, or should it be marked with a version flag (ie, only works on 6.4+)?

@richtabor
Copy link
Member Author

I don't think we have an explicit process for making a pattern "curated," but correct me if I'm wrong

No, I don't think it needs approval. Just wanted to leave a record here.

Does this pattern work with all WP versions, or should it be marked with a version flag (ie, only works on 6.4+)?

I think it's fine to include a 6.5+ flag for now.

Can you share any relevant discussion?

Only relevant discussion is on WordPress/gutenberg#60715, exploring how we can make patterns not have to rely on hard-coded left and right outer padding values, so that they're more interoperable across sites.

@richtabor
Copy link
Member Author

After more exploration, perhaps core / curated patterns can be much more oriented along this style of pattern, where they're more interoperable sections of a site, rather than the fixed values bundled with most of the patterns in the directory.

@richtabor
Copy link
Member Author

Can we get this moving? Interoperable core patterns will be key for an upcoming default WordPress theme. I'd like to explore/iterate quickly and having one added will be a solid proof of concept to expand on.

@richtabor
Copy link
Member Author

In the past we've also moved these to the wordpressdotorg user, but I don't recall if that was a requirement (it is not, technically).

Doesn't matter to me.

@ryelle
Copy link
Contributor

ryelle commented Jun 19, 2024

This has been done, you can see the pattern is part of the curated set now (on the homepage). It should appear in the API response soon, pending caches.

Updated author to wordpressdotorg.
Set locale to en_US.
Set version to 6.5.
Set viewport width to 1200.
Marked for core.

@ryelle ryelle closed this as completed Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants