Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phylopic images are broken #902

Closed
krysal opened this issue Mar 13, 2023 · 1 comment · Fixed by WordPress/openverse-catalog#1060
Closed

Phylopic images are broken #902

krysal opened this issue Mar 13, 2023 · 1 comment · Fixed by WordPress/openverse-catalog#1060
Assignees
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP 🧱 stack: catalog Related to the catalog and Airflow DAGs

Comments

@krysal
Copy link
Member

krysal commented Mar 13, 2023

Description

Today we had to exclude the Phylopic provider from search due to all the direct links being broken. I'm not sure since when this is happening but we need to fix the URLs in order to reactive this provider.

A few entries from the DB:

SELECT foreign_landing_url, url, thumbnail FROM image WHERE source = 'phylopic' LIMIT 5;

-[ RECORD 1 ]-------------------------
foreign_landing_url | http://phylopic.org/image/508c7b5d-efe4-4491-b690-a4fb5dd0463f
url                 | http://phylopic.org/assets/images/submissions/508c7b5d-efe4-4491-b690-a4fb5dd0463f.1024.png
thumbnail           | http://phylopic.org/assets/images/submissions/508c7b5d-efe4-4491-b690-a4fb5dd0463f.256.png
-[ RECORD 2 ]-------------------------
foreign_landing_url | http://phylopic.org/image/d00a8918-69bb-42d0-af34-205966ae23c4
url                 | http://phylopic.org/assets/images/submissions/d00a8918-69bb-42d0-af34-205966ae23c4.1024.png
thumbnail           | <null>
-[ RECORD 3 ]-------------------------
foreign_landing_url | http://phylopic.org/image/2a2c6c1f-bdb8-464b-bcf5-5f02d9a5ec87
url                 | http://phylopic.org/assets/images/submissions/2a2c6c1f-bdb8-464b-bcf5-5f02d9a5ec87.1024.png
thumbnail           | <null>
-[ RECORD 4 ]-------------------------
foreign_landing_url | http://phylopic.org/image/196f946f-f29f-4ca3-bdb2-5a8c5a036fd4
url                 | http://phylopic.org/assets/images/submissions/196f946f-f29f-4ca3-bdb2-5a8c5a036fd4.1024.png
thumbnail           | http://phylopic.org/assets/images/submissions/196f946f-f29f-4ca3-bdb2-5a8c5a036fd4.256.png
-[ RECORD 5 ]-------------------------
foreign_landing_url | http://phylopic.org/image/9ccaea11-774f-437b-8028-afd4ee880b36
url                 | http://phylopic.org/assets/images/submissions/9ccaea11-774f-437b-8028-afd4ee880b36.1024.png
thumbnail           | <null>

Reproduction

  1. See https://api.openverse.engineering/v1/images/?source=phylopic It's returning zero results.
{
    "result_count": 0,
    "page_count": 0,
    "page_size": 20,
    "page": 1,
    "results": []
}

Additional context

I found this while reviewing #1467 believing the problem was only with thumbnails.

@krysal krysal added 🟥 priority: critical Must be addressed ASAP 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Mar 13, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Mar 13, 2023
@AetherUnbound
Copy link
Collaborator

This could be related to #1288 (and subsequently keesey/phylopic#5).

@stacimc stacimc moved this from 📋 Backlog to ⛔ Blocked in Openverse Backlog Mar 16, 2023
@krysal krysal self-assigned this Mar 21, 2023
@obulat obulat added the 🧱 stack: catalog Related to the catalog and Airflow DAGs label Mar 27, 2023
@github-project-automation github-project-automation bot moved this from ⛔ Blocked to ✅ Done in Openverse Backlog Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP 🧱 stack: catalog Related to the catalog and Airflow DAGs
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants