Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor VWordPressLink component to use CSS for color #4998

Open
obulat opened this issue Sep 26, 2024 · 0 comments · May be fixed by #5110
Open

Refactor VWordPressLink component to use CSS for color #4998

obulat opened this issue Sep 26, 2024 · 0 comments · May be fixed by #5110
Assignees
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend

Comments

@obulat
Copy link
Contributor

obulat commented Sep 26, 2024

Problem

Most of the colors are determined using CSS-only methods. However, the VWordPressLink uses JS to set the color. This was first done because the logo is used on a background that is different from the main background color in the mobile pages modal (its background is always black, both in the dark and the light themes).

Description

Refactor the WP logo component to use the CSS-only methods of color scheme detection. The mobile nav should add a CSS variable (or change the color mode class name) to enable setting the correct color to the logo component.

Alternatives

Leave the JS method. It will be confusing long term to have the JS-based pattern still present in the app, for anyone trying to understand how to correctly style components.

Additional context

@obulat obulat added 🟩 priority: low Low priority and doesn't need to be rushed 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🧱 stack: frontend Related to the Nuxt frontend labels Sep 26, 2024
@openverse-bot openverse-bot moved this to 📋 Backlog in Openverse Backlog Sep 26, 2024
@obulat obulat mentioned this issue Sep 26, 2024
8 tasks
@obulat obulat changed the title Refactor VWordPressLink component to use Refactor VWordPressLink component to use CSS for color Sep 28, 2024
@obulat obulat self-assigned this Oct 29, 2024
@openverse-bot openverse-bot moved this from 📋 Backlog to 📅 To Do in Openverse Backlog Oct 29, 2024
@obulat obulat linked a pull request Oct 29, 2024 that will close this issue
8 tasks
@openverse-bot openverse-bot moved this from 📅 To Do to 🏗 In Progress in Openverse Backlog Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend
Projects
Status: 🏗 In Progress
Development

Successfully merging a pull request may close this issue.

1 participant