Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source thumbnails sent to photon are too small #1811

Closed
zackkrida opened this issue Apr 18, 2023 · 2 comments · Fixed by #1812
Closed

Source thumbnails sent to photon are too small #1811

zackkrida opened this issue Apr 18, 2023 · 2 comments · Fixed by #1812
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP 🧱 stack: api Related to the Django API 🧱 stack: frontend Related to the Nuxt frontend

Comments

@zackkrida
Copy link
Member

In #898 we introduced functionality which sends the URL of the upstream thumbnail to Photon if it's available and it's not from Phylopic. The motivation was so we can get the thumbnails faster and prevent timing out when images are too large.

However, many sources use unacceptably small thumbnails, with sizes in the 150-240px range, that look absolutely terrible and significantly degrade the user experience of Openverse. This is particularly evident for Flickr where many popular images are inherently older, and have very, very small thumbnails.

In the immediate we should reverse this change, and consider reimplementing after:

  1. Establishing minimum size requirements for storing a thumbnail value; clean up existing fields which do not meet the criteria
  2. or, store additional thumbnail metadata, including dimensions, so we can configure which ones to display in the frontend
@zackkrida zackkrida added 🟥 priority: critical Must be addressed ASAP 🛠 goal: fix Bug fix 🕹 aspect: interface Concerns end-users' experience with the software 🧱 stack: api Related to the Django API 🧱 stack: frontend Related to the Nuxt frontend labels Apr 18, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Apr 18, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Openverse Backlog Apr 18, 2023
@AetherUnbound
Copy link
Collaborator

@zackkrida did we want to reopen this considering your other noted points?

@krysal
Copy link
Member

krysal commented Apr 18, 2023

@AetherUnbound I created #1811 to delete the bad thumbnails after the data refresh, so we can leave this issue closed.

Howerver, another one will be needed for this point:

Establishing minimum size requirements for storing a thumbnail value

I think that will be part of #855 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP 🧱 stack: api Related to the Django API 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants