Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changes regarding issue #68092 #68093

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

ronakganatra9
Copy link

@ronakganatra9 ronakganatra9 commented Dec 18, 2024

What?

This PR will add necessary core styles to the BlockCanvas for the storybook project as discussed on #67048
and merged
https://github.com/WordPress/gutenberg/blob/trunk/platform-docs/docs/intro.md

Why?

To fix the story box component

How?

Added necessary styles as mentioned in the documenation

Testing Instructions

Find screenshot below.
image

Testing Instructions for Keyboard

Screenshots or screencast

Before Screenshot:
Image

After Screenshot:
image

Before After
Image

Copy link

github-actions bot commented Dec 18, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @ronakganatra-multidots, @ronakganatra9.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: ronakganatra-multidots, ronakganatra9.

Co-authored-by: stokesman <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @ronakganatra9! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Dec 18, 2024
Copy link
Contributor

@stokesman stokesman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I’ve yet to test this but noticed a couple things I think should be changed.

@stokesman stokesman added Storybook Storybook and its stories for components [Type] Developer Documentation Documentation for developers labels Dec 27, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this file are unrelated to the issue. Let's remove them.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't make any changes in this files, may be any autofixer like eslint or something ? Also, It removed additional spaces so it is good. Do you want me to add extra space again and re-commit the changes ?

Copy link
Contributor

@stokesman stokesman Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s showing up as part of this commit 904dd87. Maybe that was a merge of trunk into this branch? The file is already that way on trunk so it should not be showing up in the diff here anyway. I’ve seen GitHub do some strange stuff like this every once in a while and it be resolved after another push. You might try a amending one of the commit messages and then force pushing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository Storybook Storybook and its stories for components [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants