-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gallery: Add lightbox support #62906
Open
madhusudhand
wants to merge
30
commits into
trunk
Choose a base branch
from
gallery/lightbox
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
508c70e
add lightbox support to gallery block
madhusudhand 98bba76
disable and hide next/prev icons based on device
madhusudhand cc48519
remove view.js from gallery
madhusudhand c2611d0
fix a lint issue
madhusudhand e09b8ee
rename isGallery to hasNavigation and imageInit method
madhusudhand 4d4a509
adjust button opacity when disabled
madhusudhand 5dbfaed
address accessiability of lightbox navigation
madhusudhand ccbe9dc
fix accessibility: dynamic aria-label based on current image
madhusudhand 5e0df68
Try to fix a11y issues
t-hamano 0579c8e
Improve screen reader reading
t-hamano dfcca2f
move translations to server
madhusudhand 408cf80
reset gallery_id after each gallery processing
madhusudhand 3716092
fix php lint errors
madhusudhand f14acc0
Merge remote-tracking branch 'origin/trunk' into gallery/lightbox
luisherranz 1077e73
Use block context to pass down a gallery ID
luisherranz 3387ac0
Merge branch 'trunk' into gallery/lightbox
luisherranz fd51250
Fix frontend implementation
luisherranz 016ae8d
Merge branch 'trunk' into gallery/lightbox
t-hamano d229233
Fix Screen reader double reading
t-hamano e68f3a2
Don't hide lightbox when hitting Enter on prev/next buttons
t-hamano 4e0b31a
Match visual order with DOM order
t-hamano 24524c6
Do not apply opacity to focus styles on disabled prev/next buttons
t-hamano c7608c3
Add a tooltip to navigation button
t-hamano 230ab34
Add `cursor:pointer` to navigation buttons
t-hamano a9aa62b
Add focus trap
t-hamano 7ede46a
Add "Lightbox navigation" option
t-hamano deeaf40
Restore aria-live/aria-atomic
t-hamano 4f1cde2
Ajust z-index values
t-hamano 1da0337
Regenerate fixtures
t-hamano 0ed7d4c
Fix PHP lint error
t-hamano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This label
Enlarged images
now applies to both the single image and the group of images in the gallery. Previously, the message announced was way more accurate for a single image:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I adjusted the screen reader reading. NVDA reads it out as follows, but how about your software?
9bca3f2b0333352215b61aa97526289c.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's how it should work. e4ebf7d is a step in the right direction 👍🏻