Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grid item resizing in non-iframed editor. #61636

Merged
merged 2 commits into from
May 14, 2024
Merged

Fix grid item resizing in non-iframed editor. #61636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18acd97
Fix grid item resizing in non-iframed editor.
tellthemachines May 14, 2024
3e1f425
Update to use Rob's suggestion
tellthemachines May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions packages/block-editor/src/components/grid-visualizer/grid-item-resizer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ function GridItemResizerInner( {
* This ref is necessary get the bounding client rect of the resizer,
* because it exists outside of the iframe, so its bounding client
* rect isn't the same as the block element's.
* It needs to be added to a dummy element because we can't be sure if
* the popover or the resizer are on the page when we need them.
*/
const resizerRef = useRef( null );

Expand Down Expand Up @@ -131,7 +133,6 @@ function GridItemResizerInner( {
clientId={ clientId }
__unstablePopoverSlot="block-toolbar"
additionalStyles={ styles }
__unstableContentRef={ resizerRef }
>
<ResizableBox
className="block-editor-grid-item-resizer__box"
Expand Down Expand Up @@ -164,9 +165,8 @@ function GridItemResizerInner( {
* isn't directly above the handle, so we try to detect if it happens
* outside the grid and dispatch a mouseup event on the handle.
*/
const rootElementParent =
rootBlockElement.closest( 'body' );
rootElementParent.addEventListener(
controller.abort();
event.target.ownerDocument.addEventListener(
'mouseup',
() => {
event.target.dispatchEvent(
Expand Down Expand Up @@ -221,6 +221,10 @@ function GridItemResizerInner( {
controller.abort();
} }
/>
<div
className="block-editor-grid-item-resizer__dummy"
ref={ resizerRef }
></div>
</BlockPopoverCover>
);
}
Expand Down
7 changes: 7 additions & 0 deletions packages/block-editor/src/components/grid-visualizer/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,10 @@
}
}

.block-editor-grid-item-resizer__dummy {
position: absolute;
width: 100%;
height: 100%;
z-index: -1;
}

Loading