Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid interactivity: Make visualizer's cell UI at minimum 8x8 in size #61427

Closed
wants to merge 1 commit into from
Closed

Grid interactivity: Make visualizer's cell UI at minimum 8x8 in size #61427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/block-editor/src/components/grid-visualizer/grid-visualizer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,9 @@ function GridVisualizerGrid( { blockElement } ) {
style={ gridInfo.style }
>
{ Array.from( { length: gridInfo.numItems }, ( _, i ) => (
<div key={ i } className="block-editor-grid-visualizer__item" />
<div key={ i } className="block-editor-grid-visualizer__cell">
<div className="block-editor-grid-visualizer__drop-zone" />
</div>
) ) }
</div>
);
Expand Down
43 changes: 31 additions & 12 deletions packages/block-editor/src/components/grid-visualizer/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,33 +1,52 @@
// TODO: Specificity hacks to get rid of all these darn !importants.

.block-editor-grid-visualizer {
z-index: z-index(".block-editor-grid-visualizer") !important;
}
// Specificity to override the z-index and pointer-events set by .components-popover.
&.block-editor-grid-visualizer.block-editor-grid-visualizer {
z-index: z-index(".block-editor-grid-visualizer");

.block-editor-grid-visualizer .components-popover__content * {
pointer-events: none !important;
.components-popover__content * {
pointer-events: none;
}
}
}

.block-editor-grid-visualizer__grid {
display: grid;
}

.block-editor-grid-visualizer__item {
.block-editor-grid-visualizer__cell {
align-items: center;
display: flex;
justify-content: center;
}

.block-editor-grid-visualizer__drop-zone {
border: $border-width dashed $gray-300;
width: 100%;
height: 100%;

// Make drop zone 8x8 at minimum so that it's easier to drag into. This will overflow the parent.
min-width: $grid-unit-10;
min-height: $grid-unit-10;
}

.block-editor-grid-item-resizer {
z-index: z-index(".block-editor-grid-visualizer") !important;
}
// Specificity to override the z-index and pointer-events set by .components-popover.
&.block-editor-grid-item-resizer.block-editor-grid-item-resizer {
z-index: z-index(".block-editor-grid-visualizer");

.block-editor-grid-item-resizer .components-popover__content * {
pointer-events: none !important;
.components-popover__content * {
pointer-events: none;
}
}
}

.block-editor-grid-item-resizer__box {
border: $border-width solid var(--wp-admin-theme-color);

.components-resizable-box__handle {
pointer-events: all !important;
// Specificity to override the pointer-events set by .components-popover.
&.components-resizable-box__handle.components-resizable-box__handle {
pointer-events: all;
}
}
}
Loading