Fix crash when switching to code editor #61173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -55 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
@draganescu Didn't you fix this? |
ajlende
commented
Apr 29, 2024
Comment on lines
-133
to
-135
| node._load = () => { | ||
| setIframeDocument( node.contentDocument ); | ||
| }; |
There was a problem hiding this comment.
@ellatrix I'm curious why this extra _load() function was added? It seems like it should be doing the same thing as onLoad() below.
There was a problem hiding this comment.
This is not the same as document load which only happens after the initial DOM is loaded and assets are loaded. The load function is called before the browser moves on to parse any other styles and script and the body tag below. It's needed because we're rendering our own body element, which (if I remember correctly) must be available to any scripts loaded (instead of the one we're removing). See #52405.
Merged
|
This was closed by #61200 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes an issue where triggering zoom-out while the code editor was open caused an editor crash.
Why?
Bug fix.
How?
On page load, there is a script to remove the
bodyof the document so it can be replaced with the React one in the portal. However, in the effect, we're referencing thebodythat gets removed, so on unmount (when switching to the code editor) you get the error:Uncaught TypeError: iframeDocument.body is null.This is fixed by moving
body-related code inside the portal.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast