From d31cadc9d23759845984fc0067b6bfa98a37bcaf Mon Sep 17 00:00:00 2001 From: scruffian Date: Wed, 6 Mar 2024 14:16:50 +0000 Subject: [PATCH 1/3] Add a title to the category delete flow and increase line height --- packages/components/src/utils/config-values.js | 2 +- .../components/page-patterns/delete-category-menu-item.js | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/packages/components/src/utils/config-values.js b/packages/components/src/utils/config-values.js index f279bce888b9d9..2e102b8b0b77cc 100644 --- a/packages/components/src/utils/config-values.js +++ b/packages/components/src/utils/config-values.js @@ -58,7 +58,7 @@ export default Object.assign( {}, CONTROL_PROPS, TOGGLE_GROUP_CONTROL_PROPS, { fontSizeMobile: '15px', fontSizeSmall: 'calc(0.92 * 13px)', fontSizeXSmall: 'calc(0.75 * 13px)', - fontLineHeightBase: '1.2', + fontLineHeightBase: '1.4', fontWeight: 'normal', fontWeightHeading: '600', gridBase: '4px', diff --git a/packages/edit-site/src/components/page-patterns/delete-category-menu-item.js b/packages/edit-site/src/components/page-patterns/delete-category-menu-item.js index 0a9a36d93d0099..385fc0175ebfaf 100644 --- a/packages/edit-site/src/components/page-patterns/delete-category-menu-item.js +++ b/packages/edit-site/src/components/page-patterns/delete-category-menu-item.js @@ -90,6 +90,13 @@ export default function DeleteCategoryMenuItem( { category, onClose } ) { onCancel={ () => setIsModalOpen( false ) } confirmButtonText={ __( 'Delete' ) } className="edit-site-patterns__delete-modal" + title={ sprintf( + // translators: %s: The pattern category's name. + __( 'Delete the category "%s"?' ), + decodeEntities( category.label ) + ) } + size="medium" + __experimentalHideHeader={ false } > { sprintf( // translators: %s: The pattern category's name. From df5969c14bbb34ed91afb6ea8392d32c70b31f05 Mon Sep 17 00:00:00 2001 From: Ben Dwyer Date: Wed, 20 Mar 2024 11:42:09 +0000 Subject: [PATCH 2/3] reset line height --- packages/components/src/utils/config-values.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/components/src/utils/config-values.js b/packages/components/src/utils/config-values.js index 2e102b8b0b77cc..f279bce888b9d9 100644 --- a/packages/components/src/utils/config-values.js +++ b/packages/components/src/utils/config-values.js @@ -58,7 +58,7 @@ export default Object.assign( {}, CONTROL_PROPS, TOGGLE_GROUP_CONTROL_PROPS, { fontSizeMobile: '15px', fontSizeSmall: 'calc(0.92 * 13px)', fontSizeXSmall: 'calc(0.75 * 13px)', - fontLineHeightBase: '1.4', + fontLineHeightBase: '1.2', fontWeight: 'normal', fontWeightHeading: '600', gridBase: '4px', From 7de38c1fcf999963390e1d4b41a0fff03b82f93a Mon Sep 17 00:00:00 2001 From: Ben Dwyer Date: Wed, 20 Mar 2024 11:43:12 +0000 Subject: [PATCH 3/3] update the title text --- .../src/components/page-patterns/delete-category-menu-item.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/edit-site/src/components/page-patterns/delete-category-menu-item.js b/packages/edit-site/src/components/page-patterns/delete-category-menu-item.js index 385fc0175ebfaf..adb33e71816e56 100644 --- a/packages/edit-site/src/components/page-patterns/delete-category-menu-item.js +++ b/packages/edit-site/src/components/page-patterns/delete-category-menu-item.js @@ -92,7 +92,7 @@ export default function DeleteCategoryMenuItem( { category, onClose } ) { className="edit-site-patterns__delete-modal" title={ sprintf( // translators: %s: The pattern category's name. - __( 'Delete the category "%s"?' ), + __( 'Delete "%s"?' ), decodeEntities( category.label ) ) } size="medium"