From 3c4d08614e7998faf0cc2319b624a7d55249b113 Mon Sep 17 00:00:00 2001 From: Dave Smith Date: Wed, 10 Jan 2024 21:43:40 +0000 Subject: [PATCH 1/5] Show suggestions for rich text links --- packages/format-library/src/link/inline.js | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/format-library/src/link/inline.js b/packages/format-library/src/link/inline.js index 79933be6a6ac55..32d91a34660de7 100644 --- a/packages/format-library/src/link/inline.js +++ b/packages/format-library/src/link/inline.js @@ -260,6 +260,7 @@ function InlineLinkUI( { shift > Date: Wed, 10 Jan 2024 21:44:01 +0000 Subject: [PATCH 2/5] Set default search query for initial suggestions to be for pages --- .../src/fetch/__experimental-fetch-link-suggestions.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/core-data/src/fetch/__experimental-fetch-link-suggestions.js b/packages/core-data/src/fetch/__experimental-fetch-link-suggestions.js index 3bba760b20c459..98147b64bb12b8 100644 --- a/packages/core-data/src/fetch/__experimental-fetch-link-suggestions.js +++ b/packages/core-data/src/fetch/__experimental-fetch-link-suggestions.js @@ -85,7 +85,11 @@ const fetchLinkSuggestions = async ( ) => { const { isInitialSuggestions = false, - initialSuggestionsSearchOptions = undefined, + initialSuggestionsSearchOptions = { + type: 'post', + subtype: 'page', + perPage: 20, + }, } = searchOptions; const { disablePostFormats = false } = settings; From 97fa42c41f8ca7a419ef8e50318d701c93dbf903 Mon Sep 17 00:00:00 2001 From: Dave Smith Date: Wed, 24 Jan 2024 09:59:08 +0000 Subject: [PATCH 3/5] Revert "Set default search query for initial suggestions to be for pages" This reverts commit b7cb1fe7c1a4e9670c3d3bd22ed321d3cd145481. --- .../src/fetch/__experimental-fetch-link-suggestions.js | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/packages/core-data/src/fetch/__experimental-fetch-link-suggestions.js b/packages/core-data/src/fetch/__experimental-fetch-link-suggestions.js index 98147b64bb12b8..3bba760b20c459 100644 --- a/packages/core-data/src/fetch/__experimental-fetch-link-suggestions.js +++ b/packages/core-data/src/fetch/__experimental-fetch-link-suggestions.js @@ -85,11 +85,7 @@ const fetchLinkSuggestions = async ( ) => { const { isInitialSuggestions = false, - initialSuggestionsSearchOptions = { - type: 'post', - subtype: 'page', - perPage: 20, - }, + initialSuggestionsSearchOptions = undefined, } = searchOptions; const { disablePostFormats = false } = settings; From 7aeda31af76250ae8a8d205c538ef571f113120b Mon Sep 17 00:00:00 2001 From: Dave Smith Date: Wed, 24 Jan 2024 10:50:08 +0000 Subject: [PATCH 4/5] Limit change to RichText only --- packages/format-library/src/link/inline.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/packages/format-library/src/link/inline.js b/packages/format-library/src/link/inline.js index 32d91a34660de7..fb4d8c235c5f24 100644 --- a/packages/format-library/src/link/inline.js +++ b/packages/format-library/src/link/inline.js @@ -271,6 +271,14 @@ function InlineLinkUI( { createSuggestionButtonText={ createButtonText } hasTextControl settings={ LINK_SETTINGS } + suggestionsQuery={ { + // always show Pages as initial suggestions + initialSuggestionsSearchOptions: { + type: 'post', + subtype: 'page', + perPage: 20, + }, + } } /> ); From ba8eaa3b0a6ff8195713d50b2954e38b75784b8c Mon Sep 17 00:00:00 2001 From: Dave Smith Date: Wed, 24 Jan 2024 10:52:13 +0000 Subject: [PATCH 5/5] Colocate related props --- packages/format-library/src/link/inline.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/format-library/src/link/inline.js b/packages/format-library/src/link/inline.js index fb4d8c235c5f24..e477765009d1c8 100644 --- a/packages/format-library/src/link/inline.js +++ b/packages/format-library/src/link/inline.js @@ -260,7 +260,6 @@ function InlineLinkUI( { shift >