Allow button blocks to be inserted from the "Add Link" modal. #55144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torounit
added
[Type] Bug
torounit
added
[Block] Navigation
|
Size Change: +3 B (0%) Total Size: 1.65 MB
ℹ️ View Unchanged
|
getdave
added
[Type] Enhancement
getdave
reviewed
Oct 11, 2023
There was a problem hiding this comment.
Thank you for the PR and tackling this issue. Much appreciated.
Technically I believe this to be the correct approach, but I'm not going to approve it.
Why? Because I agree with Rich that there are now too many blocks in a row in this UI.
I think we should seek a more holistic solution as proposed in #50888.
If folks feel this is critical then it will need an approval from @WordPress/gutenberg-design.
|
I would echo Rich here, that I think the holistic solution is the one to go for. I do appreciate this PR, though, and if we did have to add the button it wouldn't be the worst, but it definitely isn't a scalable UI, considering translations, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Buttons block can be added by clicking on the [+] that appears inline in the navigation block.
Why?
Bug fix.
fix: #54877
How?
Add
core/buttonstofeaturedBlocksin<LinkUI />.Testing Instructions
Screenshots or screencast
2023-10-07.15.20.35.mov