Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @wordpress/menus package #31586

Closed
wants to merge 9 commits into from
Closed

Add @wordpress/menus package #31586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c6c6a33
Skeleton
getdave May 6, 2021
c8ba4a6
Correct directory field in package json
getdave May 14, 2021
791d67d
Add basic README
getdave May 7, 2021
7fa6661
Create tests stub
getdave May 14, 2021
fdcf0f7
Add comments for auto API docs
getdave May 7, 2021
70c01ed
Auto gen initial API docs
getdave May 14, 2021
622a9b7
Add menus package to root package.json
getdave May 14, 2021
f382aa2
Move menu to block data mapper to menus package and remove duplictaes…
getdave May 14, 2021
664917c
Improve docs
getdave May 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1583,6 +1583,12 @@
"markdown_source": "../packages/media-utils/README.md",
"parent": "packages"
},
{
"title": "@wordpress/menus",
"slug": "packages-menus",
"markdown_source": "../packages/menus/README.md",
"parent": "packages"
},
{
"title": "@wordpress/notices",
"slug": "packages-notices",
Expand Down
10 changes: 10 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
"@wordpress/keycodes": "file:packages/keycodes",
"@wordpress/list-reusable-blocks": "file:packages/list-reusable-blocks",
"@wordpress/media-utils": "file:packages/media-utils",
"@wordpress/menus": "file:packages/menus",
"@wordpress/notices": "file:packages/notices",
"@wordpress/nux": "file:packages/nux",
"@wordpress/plugins": "file:packages/plugins",
Expand Down
1 change: 1 addition & 0 deletions packages/block-library/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@
"@wordpress/icons": "file:../icons",
"@wordpress/is-shallow-equal": "file:../is-shallow-equal",
"@wordpress/keycodes": "file:../keycodes",
"@wordpress/menus": "file:../menus",
"@wordpress/notices": "file:../notices",
"@wordpress/primitives": "file:../primitives",
"@wordpress/reusable-blocks": "file:../reusable-blocks",
Expand Down
2 changes: 1 addition & 1 deletion packages/block-library/src/navigation/placeholder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@ import {
import { __ } from '@wordpress/i18n';
import { navigation, chevronDown, Icon } from '@wordpress/icons';
import { store as coreStore } from '@wordpress/core-data';
import { menuItemsToBlocks } from '@wordpress/menus';

/**
* Internal dependencies
*/

import PlaceholderPreview from './placeholder-preview';
import menuItemsToBlocks from './menu-items-to-blocks';

function NavigationPlaceholder( { onCreate }, ref ) {
const [ selectedMenu, setSelectedMenu ] = useState();
Expand Down
1 change: 1 addition & 0 deletions packages/edit-navigation/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
"@wordpress/interface": "file:../interface",
"@wordpress/keyboard-shortcuts": "file:../keyboard-shortcuts",
"@wordpress/media-utils": "file:../media-utils",
"@wordpress/menus": "file:../menus",
"@wordpress/notices": "file:../notices",
"@wordpress/url": "file:../url",
"classnames": "^2.2.5",
Expand Down
204 changes: 0 additions & 204 deletions packages/edit-navigation/src/store/menu-items-to-blocks.js
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion packages/edit-navigation/src/store/resolvers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
* WordPress dependencies
*/
import { createBlock } from '@wordpress/blocks';
import { menuItemsToBlocks } from '@wordpress/menus';

/**
* Internal dependencies
Expand All @@ -10,7 +11,6 @@ import { NAVIGATION_POST_KIND, NAVIGATION_POST_POST_TYPE } from '../constants';

import { resolveMenuItems, dispatch } from './controls';
import { buildNavigationPostId } from './utils';
import menuItemsToBlocks from './menu-items-to-blocks';
/**
* Creates a "stub" navigation post reflecting the contents of menu with id=menuId. The
* post is meant as a convenient to only exists in runtime and should never be saved. It
Expand Down
Loading