-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Add notices for published, updated, save failed #967
Labels
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
General Interface
Parts of the UI which don't fall neatly under other labels.
[Type] Task
Issues or PRs that have been broken down into an individual action to take
Milestone
Comments
jasmussen
added
General Interface
Parts of the UI which don't fall neatly under other labels.
Design
labels
Jun 1, 2017
Worth noting that all these notices would need an equivalent audible feedback for screen reader users. As a general rule: any "visual" notice needs to be communicated also non-visually. |
afercia
added
the
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
label
Jun 1, 2017
Let's totally use the colored versions as they are. |
Cool — they all use the
|
mtias
added
the
[Type] Task
Issues or PRs that have been broken down into an individual action to take
label
Jun 22, 2017
This was referenced Jun 26, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
General Interface
Parts of the UI which don't fall neatly under other labels.
[Type] Task
Issues or PRs that have been broken down into an individual action to take
Splitting this out from #707. The flow for publishing and saving is soon in a good place.
We have, however, a need for a few edgecase notices:
... as well as failure states:
... and also for draft saving and auto saving:
Save Failed
Let's make this part of the "Save" area on the left:
Publish/Updating/Scheduling notices
We'll probably want notices after all (see also #486), because thankfully we were able to test for a while a design where the notice itself was integrated in the button. Not only did this feel ephemeral, but it made the button itself feel more complex. It also doesn't work that well if we ever get to exploring a dropdown button as suggested in #708.
So here's how notices could look:
The text was updated successfully, but these errors were encountered: