Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable the zoom on the classic theme preview under Appearance > Design #68948

Open
carolinan opened this issue Jan 30, 2025 · 3 comments · May be fixed by #68976
Open

Disable the zoom on the classic theme preview under Appearance > Design #68948

carolinan opened this issue Jan 30, 2025 · 3 comments · May be fixed by #68976
Assignees
@singhakanshu00
Labels
[Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement. [Type] Feedback Issues that relate purely to feedback on a feature that isn't necessarily actionable

Comments

@carolinan
Copy link
Contributor

carolinan commented Jan 30, 2025 •
edited
Loading

What problem does this address?

When a classic theme adds the theme support for editor-styles, a menu item called "Design" replaces the Pattern menu, and following this link shows the dark sidebar and an iframe with the site embedded.
The preview of the front of the site replaces the preview of the editor that is shown for block themes.

This preview is not interactive, links etc are not clickable and the mouse pointer does not change when you hover over it.
I am finding the zoom when you hover the frame distracting and unpleasant.
I don't think there is a need to highlight that the preview is hovered on, since there is no clicking or interaction to encourage?
The resizer should still be visible and available.

What is your proposed solution?

Check if the zoom can be disabled and if it is an improvement.
@carolinan carolinan added [Type] Enhancement A suggestion for improvement. [Type] Feedback Issues that relate purely to feedback on a feature that isn't necessarily actionable labels Jan 30, 2025
@singhakanshu00
Copy link

singhakanshu00 commented Jan 30, 2025 •
edited
Loading

Hi, @carolinan

Yes we can disable the zoom,
zoom effect is being added by this attribute:

gutenberg/packages/edit-site/src/components/resizable-frame/index.js

Line 256 in 80348e7

whileHover={

we can remove or add a condition to disable it.

Please Let me know your thoughts.

@stokesman
Copy link
Contributor

What disgusts me is the scaling makes it smudgy (text especially). It’s only a true preview of the front end when you aren’t hovering it. For this context, I can’t imagine an argument against disabling it.

@t-hamano
Copy link
Contributor

The iframe preview of the classic theme will be released for the first time in WP 6.8, so let's add it to the 6.8 project board.

@singhakanshu00 singhakanshu00 linked a pull request Jan 31, 2025 that will close this issue
Open
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@singhakanshu00 singhakanshu00

Labels
[Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement. [Type] Feedback Issues that relate purely to feedback on a feature that isn't necessarily actionable
Projects
WordPress 6.8 Editor Tasks
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Adds an extra parameter to ResizableFrame to disable zoom singhakanshu00/gutenberg
4 participants
@carolinan @stokesman @t-hamano @singhakanshu00