Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ko-fi.com to the Social Icon block and/or add an option to a custom service button #68901

Open
asafm7 opened this issue Jan 27, 2025 · 8 comments · May be fixed by #68904
Open

Add Ko-fi.com to the Social Icon block and/or add an option to a custom service button #68901

asafm7 opened this issue Jan 27, 2025 · 8 comments · May be fixed by #68904
Assignees
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@asafm7
Copy link

asafm7 commented Jan 27, 2025

Adding Ko-fi.com to the Social Icon block and/or adding an option to a custom service button would be great.

Currently, there is a Link social block, but I can't find a way to set a custom icon for it.

Thanks.

@asafm7 asafm7 added the [Type] Enhancement A suggestion for improvement. label Jan 27, 2025
@Mayank-Tripathi32
Copy link
Contributor

I would like to work on adding it.

@Mamaduka Mamaduka added the [Block] Social Affects the Social Block - used to display Social Media accounts label Jan 27, 2025
@Mamaduka
Copy link
Member

Related #59368. This makes extending the Social Links block possible and allows consumers to add their icons easily.

@Mayank-Tripathi32
Copy link
Contributor

Related #59368. This makes extending the Social Links block possible and allows consumers to add their icons easily.

@Mamaduka But shouldn't we make it possible from editor itself without having to add filters etc?

Also Kofi is fairly popular and we should add the icon anyway I feel.

@Mamaduka
Copy link
Member

Ideally, the core should maintainn a small set of Social Icons, and the rest can be provided by community plugin(s).

I didn't say that there's should be no Ko-fi icon in core, but #59368 seems to be more future proof solution.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 27, 2025
@Mayank-Tripathi32
Copy link
Contributor

I didn't say that there's should be no Ko-fi icon in core, but #59368 seems to be more future proof solution.

Well I feel since we are having "Patreon" it makes sense to have ko-fi. I have opened a PR for the same, if not feel free to close it.

@oskar-ok-strom
Copy link

Thank you @yogeshbhutkar for making me aware of this issue.

I'm not sure exactly what format is needed for adding new social icons but I made this SVG for Ko-fi.
I took the base from https://more.ko-fi.com/brand-assets and made it more simple to work with the other icons.

ko-fi_logo.zip

If anything else is needed I'd be happy to help.

@yogeshbhutkar
Copy link
Contributor

Thanks for the help @oskar-ok-strom!

@Mayank-Tripathi32
Copy link
Contributor

Thank you @yogeshbhutkar for making me aware of this issue.

I'm not sure exactly what format is needed for adding new social icons but I made this SVG for Ko-fi. I took the base from https://more.ko-fi.com/brand-assets and made it more simple to work with the other icons.

ko-fi_logo.zip

If anything else is needed I'd be happy to help.

I have used the same asset and updated it to match the styles in WP (in the linked PR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants