Make "Show template" option persistent

[annezazu]

Right now, due to this change, the template is shown by default when editing pages. Alongside this, is a "show template" option that can be toggled on/off. Currently, if you enter a page, turn off the template, and then leave and return the show template option doesn't persist. I think making it persistent will happen lessen future feedback I'm expected from this change as folks could opt out once and move on.

[yogeshbhutkar]

I’d like to delve deeper into this enhancement. Setting this value in the preferences store seems like a solid approach. I’ll be submitting a PR to implement this soon.

[Mamaduka]

I don't think another persistent option is a solution here, and a feature introduced via #62304 can be opted out. Smart defaults should be preferred over the software options.

Let's avoid patching any editor behavior that is not final. Please look at the ongoing discussion in #62304 and #67867.

[jasmussen]

Thanks for the issue, thanks for the PR. I'd echo Mamaduka, it's not clear that making this persistent is a win, there are pros and cons. It's a good discussion tracking issue to start.

[Mamaduka]

It's a good discussion-tracking issue to start.

Definitely! I'll circle back here when this feature's implementation details are clear/final.

[joemcgill]

If we're going to experiment with this in 6.8, I think solving the persistence issue is a must so that folks who turn off the "Show Template" setting don't have to make that change every time the editor is loaded nor need to add some custom code to override this default.

I've tested #68257 and it seems to work as an initial approach, with the following observations:

• Using the preferencesStore is making this preference persist properly across different clients for the same user, which is good!
• Once set, this preference applies to all post types, which is not ideal.
• Related to the above, once manually selected, there doesn't seem to be an easy way to reset the defaults (i.e., only pages are supported).