Page List block inside navigation block will result invalid html

[saulirajala]

Description

page-list -block has features like showSubmenuIcon and openSubmenusOnClick that comes from the context provided by navigation -block, so I would assume that it's completely valid to use page-list block inside of navigation block. But doing so, will result invalid html since both navigation and page-list blocks starts with <ul>-element. So we would have <ul><ul><li>… structure, which is not allowed

Step-by-step reproduction instructions

1. Add navigation block
2. Add page-list block as inner block of navigation
3. check the html tags

The live demo of this issue is in WordPress Playground: https://playground.wordpress.net/. Inspect the navigation in header.

Screenshots, screen recording, code snippet

Environment info

• WordPress 6.5
• Twenty Twenty-Four

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

[github-actions]

Hi,
This issue has gone 30 days without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest versions, you can help the project by responding to confirm the problem and by providing any updated reproduction steps.
Thanks for helping out.

[saulirajala]

The issue still exists. Even with the latest Gutenberg plugin installed. You can verify it via WordPress Playground https://playground.wordpress.net/?plugin=gutenberg

[saulirajala]

I did PR that fixes this. You can test it in Playground PR Reviewer

[saulirajala]

Actually my solution will introduce another issue: the ul.wp-block-page-list -element&class is missing from DOM, which is not good. So we need to think another way to fix this.

[saulirajala]

Seems like core/navigation -block already has functionality to wrap inner block with <li>, but core/page-list -block was just missing from $needs_list_item_wrapper -list. Added it there, which seems to solve the issue. You can test the PR in Gutenberg PR reviewer

[github-actions]

Hi,
This issue has gone 30 days without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest versions, you can help the project by responding to confirm the problem and by providing any updated reproduction steps.
Thanks for helping out.

[saulirajala]

This is still an issue even with WordPress 6.7 RC2 and the new twentytwentyfive theme. You can test the issue in RC2 playground. I updated the pr since it had merge conflicts.

Any change to get this fixed before WP6.7 release?