Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordered list items should have a way to unset the applied HTML type attribute #54578

Closed
SteveRyan-ASU opened this issue Sep 19, 2023 · 2 comments
Labels
[Block] List Affects the List Block

Comments

@SteveRyan-ASU
Copy link

Description

Ordered lists produced by Gutenberg by using the core/list block default to a markup that looks like:

<ol>
   <li>List item</li>
</ol>

Upon applying a selection from the Numbering style dropdown, the HTML attribute type is applied to the <ol> block resulting in the following markup

<ol type="a">
   <li>List item</li>
</ol>

However, because the UI of the numbering style dropdown doesn't have a reset button or a setting for (no type) within, there is no way to "unset" this control and have it default back to the unadorned <ol> tag.

Step-by-step reproduction instructions

Start by creating an ordered list from the following content.

Congue vitae urna augue taciti torquent venenatis phasellus donec neque.
Fusce varius congue dolor lacinia.
Himenaeos sed condimentum magna venenatis erat convallis mattis?
Sodales mattis vestibulum ut erat magnis blandit.
  1. Publish the post or page and inspect the markup produced.
  2. Apply a different setting to the core/list block to enforce a specific type attribute on the block.
  3. Publish and inspect the results once again. You'll see the type attribute added to the <ol>
  4. Edit the post/page again and attempt to remove that type attribute using the default controls.

Stuck. 🙁

Screenshots, screen recording, code snippet

No response

Environment info

wp-core

version: 6.3.1
site_language: en_US
user_language: en_US
timezone: +00:00
permalink: /%postname%/
https_status: false
multisite: false
user_registration: 0
blog_public: 1
default_comment_status: open
environment_type: local
user_count: 2
dotorg_communication: true

wp-active-theme

name: Twenty Twenty-Three (twentytwentythree)
version: 1.2
author: the WordPress team

wp-plugins-active (3)

Gutenberg: version: 16.6.0, author: Gutenberg Team, Auto-updates disabled

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@t-hamano
Copy link
Contributor

Thanks for the report.The List block's Numbering Style has been changed to the inline style instead of the type attribute to resolve issues reported in #54384, #52826, etc. Its PR is #53301.

This PR does not output the inline style when the default "Numbers" style is selected. This PR will be part of WordPress 6.4 or Gutenberg plugin 16.7.

I'd like to close this issue as I don't think the reported problem will occur anymore, but if there's anything I've missed, please comment.

@t-hamano t-hamano closed this as not planned Won't fix, can't repro, duplicate, stale Sep 19, 2023
@t-hamano t-hamano added the [Block] List Affects the List Block label Sep 19, 2023
@SteveRyan-ASU
Copy link
Author

Thanks for the explanation and the references @t-hamano. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] List Affects the List Block
Projects
None yet
Development

No branches or pull requests

2 participants