Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ColorPicker: Color space dropdown has no focus style #50524

Closed
t-hamano opened this issue May 10, 2023 · 1 comment · Fixed by #50703 or #50609
Closed

ColorPicker: Color space dropdown has no focus style #50524

t-hamano opened this issue May 10, 2023 · 1 comment · Fixed by #50703 or #50609
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Components /packages/components [Type] Regression Related to a regression in the latest release

Comments

@t-hamano
Copy link
Contributor

Description

Focusing on the color space drop-down in the ColorPicker component does not change the style. Therefore, when the focus is moved by keyboard operation, it is not visible that this dropdown has the focus:

7ba0d31dc74b9f201f1b723a7c405866.mp4

The reason is that the BackdropUI to which the focus style is applied is hidden.

I would expect this element to be hidden for design reasons, but it should only be visible when it is in focus.

Step-by-step reproduction instructions

N/A

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@t-hamano t-hamano added Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Components /packages/components labels May 10, 2023
@megane9988 megane9988 mentioned this issue May 13, 2023
Merged
falgunihdesai added a commit to falgunihdesai/gutenberg that referenced this issue May 17, 2023
@falgunihdesai
Add border and focus style to the Input selector in ColorPicker
34f1bc3 
Adds backdrop to the color value type input selector in the ColorPicker component.
Previously, the backdrop for this component was hidden. Fixes WordPress#50524
@falgunihdesai falgunihdesai mentioned this issue May 17, 2023
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 17, 2023
@afercia afercia added [Type] Regression Related to a regression in the latest release [a11y] Keyboard & Focus labels May 18, 2023
@afercia
Copy link
Contributor

afercia commented May 18, 2023

Looks like this regressed with the design refactoring in #34598

@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 22, 2023
@priethor priethor added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). and removed [a11y] Keyboard & Focus labels Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Components /packages/components [Type] Regression Related to a regression in the latest release
Projects
None yet
Milestone
No milestone
3 participants
@afercia @priethor @t-hamano