Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Block: Turn off PDF embedding by default. #48486

Closed
karks88 opened this issue Feb 27, 2023 · 2 comments
Closed

File Block: Turn off PDF embedding by default. #48486

karks88 opened this issue Feb 27, 2023 · 2 comments
Labels
[Block] File Affects the File Block [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Enhancement A suggestion for improvement.

Comments

@karks88
Copy link

karks88 commented Feb 27, 2023

What problem does this address?

When using the core File block to upload a PDF document, the default behavior is to display it as an embed. This must be manually turned off each time the block is used.

What is your proposed solution?

Ideally, WordPress would remember that you've turned off displaying the file as an embed.

An alternative would be a function or setting in the block's block.json file to disable this behavior. Looking through the file, I did not see a way to do this at the present time.

@bph bph added the [Block] File Affects the File Block label Feb 27, 2023
@bph
Copy link
Contributor

bph commented Feb 27, 2023

I can see that a few site owners would find a default setting in the preferences helpful to standardize how PDFs are embedded. And developers might appreciate a parameter/attribute to turn embedd off entirely.

@bph bph added the [Type] Enhancement A suggestion for improvement. label Feb 27, 2023
@skorasaurus
Copy link
Member

Hi,

Thanks for reporting;
This has been discussed and/or requested in #34825 . Feel free to add your reaction and follow its progress in the issue.

@skorasaurus skorasaurus added the [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed label Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] File Affects the File Block [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants