Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No block settings tab is activated when you select the navigation block #47438

Closed
carolinan opened this issue Jan 26, 2023 · 6 comments
Closed
Labels
[Block] Navigation Affects the Navigation Block [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@carolinan
Copy link
Contributor

Description

With 6.2-alpha-55142 and Gutenberg trunk, neither the styles or settings tabs are active when you select the block.

Step-by-step reproduction instructions

  1. Activate a block theme
  2. Open the Site Editor
  3. Insert or select a navigation block.
  4. Notice that when the block is selected and the block settings sidebar (inspector) is open, neither the styles or settings tabs are active.

Screenshots, screen recording, code snippet

Screen.Recording.2023-01-26.at.08.23.26.mov

Environment info

With 6.2-alpha-55142 and Gutenberg trunk
Twenty Twenty-Three

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@carolinan carolinan added [Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release labels Jan 26, 2023
@ndiego
Copy link
Member

ndiego commented Jan 26, 2023

I can confirm. This occurs when the "Off canvas navigation editor" experiment is disabled.

image

@ndiego ndiego moved this to 📥 Todo in WordPress 6.2 Editor Tasks Jan 26, 2023
@ndiego ndiego added the [Priority] High Used to indicate top priority items that need quick attention label Jan 26, 2023
@annezazu
Copy link
Contributor

@getdave and @scruffian as a heads up!

@getdave
Copy link
Contributor

getdave commented Jan 27, 2023

Note that this "experiment" is now the default experience for the Plugin. Therefore I don't think this bug will occur anymore.

@draganescu
Copy link
Contributor

I think this was inadvertently fixed by #46995

@ndiego
Copy link
Member

ndiego commented Jan 27, 2023

@draganescu @getdave Yup, in my testing this looks to be fixed now with the changes that went through yesterday. @carolinan can you confirm on your end as well?

@carolinan
Copy link
Contributor Author

It is working for me now with Gutenberg trunk. The list view is activated.

@github-project-automation github-project-automation bot moved this from 📥 Todo to 🔎 Needs Review in WordPress 6.2 Editor Tasks Jan 28, 2023
@ndiego ndiego moved this from 🔎 Needs Review to ✅ Done in WordPress 6.2 Editor Tasks Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
No open projects
Development

No branches or pull requests

5 participants