Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: Publish button rendered partially off the screen #3939

Closed
gziolo opened this issue Dec 12, 2017 · 2 comments
Closed

Editor: Publish button rendered partially off the screen #3939

gziolo opened this issue Dec 12, 2017 · 2 comments
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time Mobile Web Viewport sizes for mobile and tablet devices [Type] Bug An existing feature does not function as intended

Comments

@gziolo
Copy link
Member

gziolo commented Dec 12, 2017

Issue Overview

I spent some time testing Gutenberg version 1.9.0 on my mobile device. This is a follow-up for #3197.

Steps to Reproduce (for bugs)

Open Gutenberg on iPhone 6s in Safari, iOS 11.0.3.

Expected Behavior

Everything should be displayed properly on mobile.

Current Behavior

When trying to publish a post the dropdown is partially displayed off the screen, making it really hard to use it.

image 2
@gziolo gziolo added Mobile Web Viewport sizes for mobile and tablet devices [Type] Bug An existing feature does not function as intended labels Dec 12, 2017
@gziolo gziolo assigned gziolo and unassigned gziolo Dec 12, 2017
@gziolo gziolo added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Dec 12, 2017
@brandonpayton
Copy link
Member

Current

When running an iPhone 6S on the iOS Simulator, I'm seeing the same issue but with the menu off the left hand side.

iphone-6s-publish-dropdown

Options

Based on the screenshots with the menu off the left and right sides, it appears the popover is too wide to be aligned with the left or right of the Publish button. Ideally, what should we be seeing?

Should we keep the same menu style but shift the box horizontally to fit in the window?

Should we expand this menu for mobile instead as seen below? Please ignore the incorrect content width.

iphone-6s-publish-dropdown-mobile

@gziolo
Copy link
Member Author

gziolo commented Dec 21, 2017

It might get fixed by PR opened by @youknowriad #4119 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time Mobile Web Viewport sizes for mobile and tablet devices [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@youknowriad @brandonpayton @gziolo