Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parent block delayed re-render after inner block move in Safari #30299

Closed
tlovett1 opened this issue Mar 26, 2021 · 3 comments · Fixed by #30995
Closed

Parent block delayed re-render after inner block move in Safari #30299

tlovett1 opened this issue Mar 26, 2021 · 3 comments · Fixed by #30995
Labels
Browser Issues Issues or PRs that are related to browser specific problems Needs Dev Ready for, and needs developer efforts [Type] Performance Related to performance efforts

Comments

@tlovett1
Copy link

tlovett1 commented Mar 26, 2021

Description

I've encountered an issue in Safari when inner blocks are moved. Although the inner blocks move correctly, the parent block sometimes receives the updated inner blocks with their new ordering after a few second delay. This does not happen in Chrome.

This could be related to #30249

Step-by-step reproduction instructions

I've created a proof of concept block to reproduce the problem:

Code: https://gist.github.com/tlovett1/2c49074bc4ed6931e914bb2bd1bf92d1

Screenshots or screen recording (optional)

Video showing the problem:

parent.rerender.delay2.mov

WordPress information

  • WordPress version: 5.7
  • Gutenberg version: 10.2.1
  • Are all plugins except Gutenberg deactivated? Yes
  • Are you using a default theme (e.g. Twenty Twenty-One)? Yes

Device information

  • Operating system: macOS 10.15.7
@gziolo
Copy link
Member

gziolo commented Mar 26, 2021

Thanks for the report with the very detailed reproduction 👍🏻

It looks similar to #28166 that seems to be fixed in #29892 by @ellatrix. We would need to re-test with the Gutenberg 10.3-rc1 and see if it's still valid.

I see another similar report related to nested blocks and Safari in #19454.

Another one: #29678.

@gziolo gziolo added Needs Testing Needs further testing to be confirmed. Browser Issues Issues or PRs that are related to browser specific problems labels Mar 26, 2021
@Mamaduka
Copy link
Member

I was able to reproduce the issue with Gutenberg 10.3.2 and Safari 14.0.3.

Unfortunately, I'm not 100% sure what the next steps of debugging should be.

@gziolo gziolo added Needs Dev Ready for, and needs developer efforts [Type] Performance Related to performance efforts and removed Needs Testing Needs further testing to be confirmed. labels Apr 13, 2021
@Mamaduka
Copy link
Member

Same as #30249 and should be fixed by #30995

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Browser Issues Issues or PRs that are related to browser specific problems Needs Dev Ready for, and needs developer efforts [Type] Performance Related to performance efforts
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants