Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow updateBlockAttributes on Safari #29370

Closed
jegbagus opened this issue Feb 26, 2021 · 2 comments
Closed

Slow updateBlockAttributes on Safari #29370

jegbagus opened this issue Feb 26, 2021 · 2 comments
Labels
Browser Issues Issues or PRs that are related to browser specific problems Needs Testing Needs further testing to be confirmed.

Comments

@jegbagus
Copy link

Description

Very slow updateBlockAttributes on Safari 14.0.3 (macOs big sur)

Step-by-step reproduction instructions

  1. loop child block from parent.
  2. do updateBlockAttributes of child attribute from parent.

Expected behaviour

updateBlockAttributes should be happened instantly. this kind of behavior not happen on other browser (firefox, google chrome, microsoft edge)

Actual behaviour

very slow update when updateBlockAttributes executed on safari.

Screenshots or screen recording (optional)

https://share.getcloudapp.com/RBu4rXDn

Code snippet (optional)

useEffect(() => {
        if (isSelected) {
            const rootId = getBlockRootClientId(clientId);
            const childs = getBlocks(rootId);

            childs.map(child => {
                if (child.clientId !== clientId) {
                    updateBlockAttributes(child.clientId, { active: false });
                }
            });

            setAttributes({ active: true });
        }
    }, [isSelected]);

WordPress information

  • WordPress version: 5.6.2
  • Gutenberg version: 10.0.1
  • Are all plugins except Gutenberg deactivated? No
  • Are you using a default theme (e.g. Twenty Twenty-One)? Yes

Device information

  • Device: iMac
  • Operating system: macOs Big Sur
  • Browser: Safari 14.0.3
@skorasaurus skorasaurus added Needs Testing Needs further testing to be confirmed. Browser Issues Issues or PRs that are related to browser specific problems labels Feb 28, 2021
@ellatrix
Copy link
Member

Is this fixed by #30995?

@ellatrix
Copy link
Member

Should be fixed after #30995. Please reopen if that's not the case :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Browser Issues Issues or PRs that are related to browser specific problems Needs Testing Needs further testing to be confirmed.
Projects
None yet
Development

No branches or pull requests

3 participants