Skip to content

Commit

Permalink
Update lable of height control for cover
Browse files Browse the repository at this point in the history
  • Loading branch information
akasunil committed Jun 17, 2024
1 parent 4549f74 commit f641ce9
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ function CoverHeightInput( {

return (
<HeightControl
label={ __( 'Minimum height of cover' ) }
label={ __( 'Minimum height' ) }
value={ computedValue }
onChange={ handleOnChange }
/>
Expand Down
5 changes: 2 additions & 3 deletions packages/block-library/src/cover/test/edit.js
Original file line number Diff line number Diff line change
Expand Up @@ -372,9 +372,8 @@ describe( 'Cover block', () => {
} )
);

const [ heightControl ] = screen.getAllByLabelText(
/Minimum height of cover/
);
const [ heightControl ] =
screen.getAllByLabelText( /Minimum height/ );

await userEvent.clear( heightControl );
await userEvent.type( heightControl, '300' );
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/specs/editor/blocks/cover.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -156,9 +156,9 @@ test.describe( 'Cover', () => {
.getByRole( 'tab', { name: 'Styles' } )
.click();

// Ensure there the default value for the minimum height of cover is undefined.
// Ensure there the default value for the Minimum height is undefined.
const defaultHeightValue = await coverBlockEditorSettings
.getByRole( 'slider', { name: 'Minimum height of cover' } )
.getByRole( 'slider', { name: 'Minimum height' } )
.inputValue();
expect( defaultHeightValue ).toBeFalsy();

Expand Down

0 comments on commit f641ce9

Please sign in to comment.