update: store overlay style to variable for better readibility and pe…

…rformance
WordPress · Jun 17, 2024 · e34a16b · e34a16b
1 parent 59286b1
commit e34a16b
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/packages/block-library/src/navigation/index.php b/packages/block-library/src/navigation/index.php
@@ -519,6 +519,8 @@ private static function get_responsive_container_markup( $attributes, $inner_blo
 			';
 		}
 
+		$overlay_inline_styles = esc_attr( safecss_filter_attr( $colors['overlay_inline_styles'] ) );	
+
 		return sprintf(
 			'<button aria-haspopup="dialog" %3$s class="%6$s" %10$s>%8$s</button>
 				<div class="%5$s" %7$s id="%1$s" %11$s>
@@ -537,7 +539,7 @@ private static function get_responsive_container_markup( $attributes, $inner_blo
 			$toggle_aria_label_close,
 			esc_attr( implode( ' ', $responsive_container_classes ) ),
 			esc_attr( implode( ' ', $open_button_classes ) ),
-			( ! empty( esc_attr( safecss_filter_attr( $colors['overlay_inline_styles'] ) ) ) ) ? ( 'style="' . esc_attr( safecss_filter_attr( $colors['overlay_inline_styles'] ) ) . '"' ) : '',
+			( ! empty( $overlay_inline_styles ) ) ? "style=$overlay_inline_styles" : '',
 			$toggle_button_content,
 			$toggle_close_button_content,
 			$open_button_directives,