From 7b5408f02dc5d3b6cc04ccd1e77353f268fc8075 Mon Sep 17 00:00:00 2001 From: Jarda Snajdr Date: Mon, 18 Dec 2023 08:44:48 +0100 Subject: [PATCH] Tidy up the uncategorized condition --- .../pattern-category-previews.js | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/packages/block-editor/src/components/inserter/block-patterns-tab/pattern-category-previews.js b/packages/block-editor/src/components/inserter/block-patterns-tab/pattern-category-previews.js index 800ffa9867ef20..071a9c479003fa 100644 --- a/packages/block-editor/src/components/inserter/block-patterns-tab/pattern-category-previews.js +++ b/packages/block-editor/src/components/inserter/block-patterns-tab/pattern-category-previews.js @@ -78,19 +78,19 @@ export function PatternCategoryPreviews( { return true; } - if ( category.name !== 'uncategorized' ) { - return pattern.categories?.includes( category.name ); - } + if ( category.name === 'uncategorized' ) { + // The uncategorized category should show all the patterns without any category... + if ( ! pattern.categories ) { + return true; + } - // The uncategorized category should show all the patterns without any category - // or with no available category. - if ( ! pattern.categories ) { - return true; + // ...or with no available category. + return ! pattern.categories.some( ( catName ) => + availableCategories.some( ( c ) => c.name === catName ) + ); } - return ! pattern.categories.some( ( catName ) => - availableCategories.some( ( cat ) => cat.name === catName ) - ); + return pattern.categories?.includes( category.name ); } ), [ allPatterns,