From 194d208c68e4d234c43c7d0c3d3db55df56c367e Mon Sep 17 00:00:00 2001 From: Lena Morita Date: Fri, 9 Feb 2024 22:17:22 +0900 Subject: [PATCH] Tabs: Fix infinite loop in useEffect (#58861) Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: andrewhayward Co-authored-by: youknowriad --- packages/components/CHANGELOG.md | 1 + packages/components/src/tabs/index.tsx | 8 +------- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/packages/components/CHANGELOG.md b/packages/components/CHANGELOG.md index 64c9b5cd985c01..f4e84bd26ca55f 100644 --- a/packages/components/CHANGELOG.md +++ b/packages/components/CHANGELOG.md @@ -26,6 +26,7 @@ - `Placeholder`: Fix Global Styles typography settings bleeding into placeholder component ([#58303](https://github.com/WordPress/gutenberg/pull/58303)). - `PaletteEdit`: Fix palette item accessibility in details view ([#58214](https://github.com/WordPress/gutenberg/pull/58214)). - `Snackbar`: Fix the auto-dismissal timers ([#58604](https://github.com/WordPress/gutenberg/pull/58604)). +- `Tabs`: Fix infinite loop in `useEffect` ([#58861](https://github.com/WordPress/gutenberg/pull/58861)). ### Experimental diff --git a/packages/components/src/tabs/index.tsx b/packages/components/src/tabs/index.tsx index 4573f7a6968df9..685c5cb32bd05a 100644 --- a/packages/components/src/tabs/index.tsx +++ b/packages/components/src/tabs/index.tsx @@ -151,13 +151,7 @@ function Tabs( { if ( tabsHavePopulated.current && !! selectedTabId && ! selectedTab ) { setSelectedId( null ); } - }, [ - isControlled, - selectedId, - selectedTab, - selectedTabId, - setSelectedId, - ] ); + }, [ isControlled, selectedTab, selectedTabId, setSelectedId ] ); useEffect( () => { if ( ! isControlled ) {