Skip to content

Commit

Permalink
Remove the property from the user variation before merginng it with t…
Browse files Browse the repository at this point in the history
…he new variation
  • Loading branch information
scruffian committed Jun 14, 2024
1 parent 907d244 commit 115032d
Showing 1 changed file with 13 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -68,14 +68,14 @@ export function useCurrentMergeThemeStyleVariationsWithUserConfig( {
variationsFromTheme: _variationsFromTheme || [],
};
}, [] );
const { user: baseVariation } = useContext( GlobalStylesContext );
const { user: userVariation } = useContext( GlobalStylesContext );

return useMemo( () => {
const clonedBaseVariation = cloneDeep( baseVariation );
const clonedUserVariation = cloneDeep( userVariation );

// Get user variation and remove the settings for the given property.
const userVariation = removePropertyFromObject(
clonedBaseVariation,
const userVariationWithoutProperty = removePropertyFromObject(
clonedUserVariation,
property
);
userVariation.title = __( 'Default' );
Expand All @@ -85,11 +85,17 @@ export function useCurrentMergeThemeStyleVariationsWithUserConfig( {
return isVariationWithSingleProperty( variation, property );
} )
.map( ( variation ) => {
return mergeBaseAndUserConfigs( baseVariation, variation );
return mergeBaseAndUserConfigs(
userVariationWithoutProperty,
variation
);
} );

return [ userVariation, ...variationsWithSinglePropertyAndBase ];
}, [ property, baseVariation, variationsFromTheme ] );
return [
userVariationWithoutProperty,
...variationsWithSinglePropertyAndBase,
];
}, [ property, userVariation, variationsFromTheme ] );
}

/**
Expand Down

0 comments on commit 115032d

Please sign in to comment.