-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Modal
: fix closing when contained iframe is focused (#51602)
* Fix modal closing when a contained iframe is focused Remove focus outside hook. * Test: add iframe to Modal component * Monopolize open modal * Revise comment * Remove needless condition * Avoid running effect due to unstable prop * Permit nested Modals * Robustly support nested Modals * Preserve current behavior for nested modals * Split effect to separate concerns * Add unit test for request closing of nested modals * Call onRequestClose for nested modal when outer modal unmounts * Comment and rename per feedback * Add changelog entry * Revert "Test: add iframe to Modal component" This reverts commit 6502514. * Fix changelog --------- Co-authored-by: Tetsuaki Hamano <[email protected]>
- Loading branch information
Showing
3 changed files
with
91 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0816b4c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flaky tests detected in 0816b4c.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6424253735
📝 Reported issues:
/test/e2e/specs/editor/various/multi-block-selection.spec.js