Remove white spaces from theme slugs

[matiasbenedetto]

What?

• Remove white spaces from the theme slug
• Removing the removal of the key in the template parts links in templates because this is not necessary.

How to test?

Follow the steps detailed in the description of: #242

Fixes: #242

[oskosk]

This worked well for me following the steps of #242!

[oskosk]

When testing this PR it worked for me. I copied the file's content and pasted it on a site running Create Block Theme 1.6.0...

But after 1.6.1 was released, I faced this bug again on a fresh site with Create Block Theme 1.6.1. The same steps as described in #242, but the template is now indeed exported referencing the part with spaces stripped on the theme attribute.

In this capture, I show the new site where I uploaded the recently generated theme from another site (with Create Block Theme 1.6.1).

You can see that the theme attribute is there without spaces, but the part does not render.

Edit: See #244 (comment)

Screen.Recording.2023-02-28.at.13.55.36.mov

[oskosk]

When testing this PR it worked for me. I copied the file's content and pasted it on a site running Create Block Theme 1.6.0...

I'm sorry, but I think I didn't test properly at the time. I just retested doing this ⬆️ and the problem persisted in 1.6.0 with the changes from the PR applied

Edit: See #244 (comment)

[oskosk]

Ok, I found out what happened. I was uploading a file named letheme (2).zip (a result of downloading multiple times) that ended up creating a folder named letheme-2 in the site, so the editor requests to wp-json/wp/v2/template-parts/letheme//header?context=edit&_locale=user were failing. Sorry for the noise