-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review templates - Lesson #869
Comments
Draft Lesson: https://github.com/jonathanbossenger/block-theme-course/blob/main/module-01/02-Review-Templates.md I have not taken screenshots at this time, as I want to make sure to take screenshots following the contents of the Create a Block Theme (Low Code) course, which I will do once the first few modules of that course are ready to be reviewed. |
Thanks for the review feedback @westnz
It was supposed to be 'In the last lesson, you created an empty index.html template file.' Fixed
Yes, I noticed this as well, and I plan to add a 1px border around the images. I actually had this exact same issue when I was creating content at my previous position, we had an inline CSS snippet we had to add to each and every image. 🙈
As discussed in the previous review comments, yes. Unfortunately, they just don't exist on GitHub.
Thanks for picking this up, I started adding the Do or Note or Tip heading to the quote blocks in markdown about halfway through this module when the idea came to me, and probably forgot to go back and ensure they were all there. Fixed
This is probably only because I've not applied any styles via theme.json to the theme yet, so there's no layout or spacing implemented on the theme itself.
I was confused by this one, as the developer handbook has it as Site Editor, but the support handbook does not. However, I'll make sure to stick to Site Editor going forward. Fixed (as well as the rest of the spelling/punctuation errors. |
Great stuff!
|
When would you do each? I'd touch on that a bit to share some best practices. Otherwise, this looks solid to me! |
Thanks for the feedback @annezazu
That's a solid point, I'll add some content around when you might do each. |
Remove comma between themes and is :) /EDIT/ - I didn't see there was more information below a screenshot! Facepalm... reviewing properly now..
"Go ahead and add a query loop to the template, the pagination block, and a spacer to allow a bit of space between the query loop and the pagination." Random Thoughts - I wonder if a tutorial on theme blocks might be useful to refer to as a form of remediation. I'm not sure your audience will necessary need that, but it's something to consider. :) Otherwise, this looks good so far! |
Thanks for the feedback @wparasae I've made the updates and suggestions. |
IMPORTANT
This lesson plan belongs to part of a greater course, Extend a Low Code Block Theme which depends on the completion of Create a Custom Block Theme #1
Please reach out to @jonathanbossenger (Jonathan Bossenger) in the #training team Slack if you would like to help with this lesson plan.
Topic Description
The goal of this lesson is to review how creating templates work in a block theme, reviewing this lessons from the first course
This lesson will also cover some of the additional templates that can be created from the Site Editor, for example:
Objectives
After completing this lesson, participants will be able to:
Guidelines
Review the [team guidelines] (https://make.wordpress.org/training/handbook/guidelines/)
Lesson for review:
Block Theme Templates
Review checklist
Reviewers: this is not an extensive list, but it would be helpful if you can keep the following questions in mind while reviewing.
The text was updated successfully, but these errors were encountered: