Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected return from GetConnectedDevicesInfo when no devices are connected #9

Open
diogotr7 opened this issue Jan 10, 2023 · 1 comment · May be fixed by #10
Open

Unexpected return from GetConnectedDevicesInfo when no devices are connected #9

diogotr7 opened this issue Jan 10, 2023 · 1 comment · May be fixed by #10

Comments

@diogotr7
Copy link

If the SDK is working correctly but zero devices were found, the return value of the method is zero.

The wrapper around the method seems to cover cases when the return from the sdk is negative (error) and positive (there are devices and we need to convert the pointer to a struct), but does not cover it being zero (according to other methods, i would expect the return Tuple to be (0, WootingAnalogResult.Ok). This is the behaviour of the ReadAnalog and Initialise methods
@diogotr7 diogotr7 linked a pull request Jan 10, 2023 that will close this issue
Open
@diogotr7
Copy link
Author

I'm not sure if this is 'intended' behaviour or not, but i fel it should at least be consistent between all of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed unexpected return value in GetConnectedDevicesInfo diogotr7/wooting-analog-wrappers
1 participant
@diogotr7