Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in augmentation configuration #220

Open
domef opened this issue Nov 3, 2022 · 1 comment
Open

Bug in augmentation configuration #220

domef opened this issue Nov 3, 2022 · 1 comment

Comments

@domef
Copy link
Contributor

domef commented Nov 3, 2022

In SSDAugmentation and SSDAugmentationVideo there is an error in the enabling of the rotation augmentation. The line enable_if(cfg.augment_random_flip, RandomRot90()) should be converted in enable_if(cfg.augment_random_rot90, RandomRot90()) in both classes.

https://github.com/haotian-liu/yolact_edge/blob/3f423ede1aeac73dbf86dadfe85af9e288f7f99b/yolact_edge/utils/augmentations.py#L908

https://github.com/haotian-liu/yolact_edge/blob/3f423ede1aeac73dbf86dadfe85af9e288f7f99b/yolact_edge/utils/augmentations.py#L932
@domef
Copy link
Contributor Author

domef commented Nov 4, 2022

I fixed the bug and created a pull request: #221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@domef