Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #551

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Fix CI #551

wants to merge 4 commits into from

Conversation

dmunozv04
Copy link
Contributor

Proposed changes

CI had a couple of issues. First, since ubuntu 22.04, the actions runner has grunt preinstalled so there's no need for us to install it. Also, it now only attempts to login to docker hub and quay.io if its environment variable has been set

Types of changes

What types of changes does your code introduce to the project: Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...

@coveralls
Copy link

coveralls commented Nov 12, 2024

Coverage Status

coverage: 88.21%. first build
when pulling ff2601a on dmunozv04:fix-ci
into c4e942f on Wirecloud:develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants