Display users in table in Admin Settings #149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* docs(contributor): contrib-readme-action has updated readme * Move item to bottom of list --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
) * Set location of PouchDB log file with environment variable. * Use config system * Use config system --------- Co-authored-by: Wingy <[email protected]>
* Added automation to keep contributers section current * Updated README.md to use new automation to keep contributers current * changed branch name * fix: Added backslashes and typescript install to Dockerfile * fix: Dockerfile, allow changes to be applied --------- Co-authored-by: jskidie <[email protected]>
Wingysam
reviewed
Oct 11, 2024
src/views/adminSettings.pug
Outdated
| each user in users | ||
| tr(id=user.id) | ||
| td=user.id | ||
| td=user.doc.admin |
There was a problem hiding this comment.
I'd like this to use the localized equivalent of yes or no rather than true/false. Something like:
= user.doc.admin ? lang('YES') : lang('NO')Other than that this looks great! It's a lot more intuitive, thank you.
There was a problem hiding this comment.
Yep, makes sense. Done in cc185ca
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users in the Admin Settings area are displayed in a table. This should make it more obvious to admins that they can perform actions on those users like reset passwords, etc.
What it looks like on desktop:
And on mobile:
Closes #129 if accepted.