Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Double-clicking in pip mode does not activate original window's double-click function #367

Open
saxyx opened this issue Aug 14, 2024 · 4 comments
Labels
bug Something isn't working compatibility-issue

Comments

@saxyx
Copy link

saxyx commented Aug 14, 2024

When using the Picture-in-Picture (PiP) feature in WindowTop, I've noticed that double-clicking on the PiP window doesn't behave as I anticipated. Instead of pausing playback in the original window, like it typically does in video players, nothing happens. This hinders the seamless use of PiP, as I often rely on double-clicks to control playback. It would be highly beneficial if double-clicks in PiP could pause playback in the original window, just as they do when interacting directly with the video.

Thank you so much ^^

@gileli121
Copy link
Member

gileli121 commented Aug 17, 2024

Hello, thanks for letting me know about this problem.
What program do you use with the PiP function, and on what do you try to perform double click in this program?
Other mouse operation work besides double-clicking? Keep in mind that the "INTERACT" button should be enabled.

By the way, it is enabled by Default for a few applications, such as Google Chrome, Edge, and more.
If you want, you can add more applications to the list so that it is enabled by Default. More information about it here:

https://windowtop.info/features/pip-picture-in-picture-crop/

Under Default apps/windows, where interact () is enabled by Default,

@saxyx
Copy link
Author

saxyx commented Aug 18, 2024

Thank you for your prompt response. I'm encountering this issue while using PotPlayer for local video playback. Specifically, I rely on double-clicks to pause or resume the video, which is a common feature in video players.

I have already ensured that the "INTERACT" button is enabled, allowing interactions with the original window through the PiP mode. However, upon enabling PiP for PotPlayer, I've noticed that all mouse operations work as expected except for double-clicks. Double-clicking the PiP window does not trigger the pause/play function as it should, hindering the seamless experience.

@gileli121
Copy link
Member

gileli121 commented Aug 18, 2024

@saxyx

I checked it with PotPlayer and reproduced the issue.
I was surprised to find out that mouse interaction even works with PotPlayer :)
It is enabled by default for a specific list of applications because it does not work for every app. I may add PotPlayer to the default list after it is fixed.

Thank you for bringing this to my attention. Your report is invaluable in helping improve mouse interaction.
For now, you can configure another mouse button for pause/resume
For example, you can use the mouse's middle button.
I know about PotPlayer, and it has the option to change it if you interested.

I hope to work on bugs like this one soon.

@gileli121 gileli121 added bug Something isn't working compatibility-issue labels Aug 18, 2024
@saxyx
Copy link
Author

saxyx commented Aug 18, 2024

Thank you so much for verifying the issue with PotPlayer and for your thoughtful response.
I've modified the Potplayer options and solved my problem.
I will wait patiently for the bug to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compatibility-issue
Projects
None yet
Development

No branches or pull requests

2 participants