Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should kongplete enable default shell completions? #15

Open
chairmank opened this issue May 7, 2022 · 0 comments
Open

Should kongplete enable default shell completions? #15

chairmank opened this issue May 7, 2022 · 0 comments

Comments

@chairmank
Copy link

I explored whether kongplete could be used to implement shell completion in https://github.com/jotaen/klog, and I discovered that the user experience was unsatisfactory because kongplete does not enable default shell completions for things like file paths. (See jotaen/klog#177 for details.) This could be achieved by changing the commands in shellInstall map. For example, the change for bash would be from

"complete -C ${bin} ${cmd}\n"

to

"complete -o default -o bashdefault -C ${bin} ${cmd}\n"

It seems to me that this change would improve the usability of completions. Is there a reason why kongplete does not already do this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant