Properly handle arrow up key in search suggestion navigation

mmeller-wikia · mmeller-wikia · commit 16a15314a52c · 2020-12-02T09:56:20.000+01:00
diff --git a/source/components/GlobalNavigation/components/Search/Search.js b/source/components/GlobalNavigation/components/Search/Search.js
@@ -87,7 +87,7 @@ class Search extends React.Component {
 
                 break;
             // up arrow
-            case 30:
+            case 38:
                 if (suggestions.length && selectedSuggestionIndex > -1) {
                     this.setState(({ selectedSuggestionIndex: selectedSuggestionIndex - 1 }));
                 }

Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,7 @@ class Search extends React.Component {`
`87`	`87`
`88`	`88`	`break;`
`89`	`89`	`// up arrow`
`90`		`- case 30:`
	`90`	`+ case 38:`
`91`	`91`	`if (suggestions.length && selectedSuggestionIndex > -1) {`
`92`	`92`	`this.setState(({ selectedSuggestionIndex: selectedSuggestionIndex - 1 }));`
`93`	`93`	`}`