Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for .MP4 files #51

Closed
RobinAtRestore opened this issue Jun 1, 2023 · 8 comments
Closed

Support for .MP4 files #51

RobinAtRestore opened this issue Jun 1, 2023 · 8 comments
Assignees
Labels
area: content Content of pages, file contents etc. asset: attachments This issue is about page attachments

Comments

@RobinAtRestore
Copy link

Hi

The trial version of WikiTraccs doesn't support the transfer of MP4 files, is this a restriction in the trial version or something that is not supported at all ?

If it's the latter (not supported) then is there a plan to add this support at all ?

Thanks

Robin

@heinrich-ulbricht
Copy link
Contributor

heinrich-ulbricht commented Jun 1, 2023

@RobinAtRestore I remember migrating gigabytes of MP4 page attachments from Confluence to SharePoint, so this should work. No restriction in the trial either.

There is a list of blocked file types in SharePoint, like .jar, but this does not include MP4.

How does this look like in your case?

General:

  • Are all MP4 files affected, or only some?
  • How are the missing MP4 files reported (they should be reported if missing)?
  • How did you discover those files are missing (visual check, log file, page metadata, ...)?

Looking at SharePoint:

  • Are the actual MP4 files missing in SharePoint when looking in the page's attachment list, or are the files present as page attachments, but not embedded (anymore) in the page content?
  • Are the MP4 files present, but just not shown in the page because the macro is missing? (This might be the case and reminds me of Place YouTube links in a web part #45.)
  • Is there an error in the log files (search for an expected file name)? (I can help with diagnosing the logs if you send them over to [email protected] )

Looking at Confluence:

  • Are those MP4 files mere page attachments, or embedded in the page(s)? Using which macro?
  • Are those MP4 files direct attachments of the migrated source Confluence page(s)?
  • Are the attachments on the same page or are those files embedded from another Confluence page or space (has this other space been migrated, yet? The MP4 files will be present over there.)
  • Are those files embedded from an external source? WikiTraccs does not download externally linked files, except images.

We'll figure this out.

@heinrich-ulbricht heinrich-ulbricht self-assigned this Jun 1, 2023
@heinrich-ulbricht heinrich-ulbricht added area: content Content of pages, file contents etc. asset: attachments This issue is about page attachments labels Jun 1, 2023
@RobinAtRestore
Copy link
Author

RobinAtRestore commented Jun 1, 2023

Hi,

Some more information...

  • The file has been copied across into sharepoint in the expected folder.

  • The error message displayed is "🚧 Cannot handle image 'Create a Customer Demo.mp4'"

  • the log file has probably the most useful piece of information:
    [015 12:15:28 DBG 3315597352 SolutionsDesign] [https://edmgroup.atlassian.net/wiki] Trying to get attachment 'Create a Customer Demo.mp4' from attachment store | WikiTraccs.Console.Transformation.My.PageTransformator
    [015 12:15:28 WRN 3315597352 SolutionsDesign] [https://edmgroup.atlassian.net/wiki] Image is broken: 'C:\Users\robinsmith\AppData\Local\WikiTraccs\64086d559ce2cd2c2410b6f1\https___edmgroup.atlassian.net_wiki\Attachments\3315597352\att3315597360\Create a Customer Demo.mp4'; image format cannot be determined; skipping image (Message: Image cannot be loaded. Available decoders:

  • GIF : GifDecoder

  • JPEG : JpegDecoder

  • TIFF : TiffDecoder

  • BMP : BmpDecoder

  • PNG : PngDecoder

  • TGA : TgaDecoder

  • PBM : PbmDecoder

  • Webp : WebpDecoder
    ) | WikiTraccs.Console.Transformation.My.PageTransformator

  • I'm not sure how to answer the confluence questions, but when I view the source of the page when editing the confluence page, the html surrounding the video is:

Thanks

Robin

@heinrich-ulbricht
Copy link
Contributor

Interesting! It thinks the video is an image! Will look into that. Thanks.

@heinrich-ulbricht
Copy link
Contributor

@RobinAtRestore No this is strange.

Somehow the video is - technically - embedded as image!?

I don't know how to reproduce this. When I drag and drop an MP4 file to a Confluence page it looks like this, here one time as preview, and another time as link:

video-preview

The storage format looks like this:

<p>
    <ac:structured-macro ac:name="view-file" ac:schema-version="1"
        ac:macro-id="41cf12c9-72c9-4b7c-8dc6-ef108f8f0621">
        <ac:parameter ac:name="name">
            <ri:attachment ri:filename="test.mp4" />
        </ac:parameter>
        <ac:parameter ac:name="height">250</ac:parameter>
    </ac:structured-macro>
</p>
<p>
    <ac:link>
        <ri:attachment ri:filename="test.mp4" />
    </ac:link>
</p>

This works and looks as expected in SharePoint:

mp4embed2

Could you send me the storage format of an affected page please ( [email protected] ) - hopefully the following option is present:

image

This should make things clearer.

@heinrich-ulbricht
Copy link
Contributor

After reviewing the storage format I can confirm that the following construct in the Confluence page causes the issue:

<ac:image ac:align="center" ac:layout="center" ac:original-height="1080" ac:original-width="1920">
   <ri:attachment ri:filename="Create a Customer Demo.mp4" ri:version-at-save="1" />
</ac:image>

This is an image element referencing a video file. WikiTraccs does not know yet that this is even possible. That's something for a next release to be handled properly. It should fall back to video migration behavior, which is: inserting a link to the video attachment into the SharePoint page.

@heinrich-ulbricht
Copy link
Contributor

heinrich-ulbricht commented Jun 4, 2023

@RobinAtRestore Handling of image elements that in fact point to a video has been added in the latest release v1.3.13. Could you please try re-migrating some of the affected pages with the new version? (Delete them in SharePoint, before migrating again.)

The implementation is based on the storage format I got from you/your colleague. Let's see if it covers all affected cases - please report back. Thanks!

@RobinAtRestore
Copy link
Author

Hi

i can confirm that after the latest upgrade, the file is now linked on the migrated page:

image

Thanks for your help on this.

Robin

@heinrich-ulbricht
Copy link
Contributor

@RobinAtRestore You're welcome, thanks for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: content Content of pages, file contents etc. asset: attachments This issue is about page attachments
Projects
None yet
Development

No branches or pull requests

2 participants