You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 11, 2023. It is now read-only.
It seems that Google Groups authorization checks user membership in groups on every HTTP request. This is suboptimal. Should probably check only once before issuing TOKEN cookie. Then, in case TOKEN cookie is still valid, it should assume that user is authorized without checking group membership again.
The text was updated successfully, but these errors were encountered:
Agreed. This may involve a bit of a larger change. The original concept was that we decouple authentication and authorization such that the user is first authenticated and then authorized. The authorization step was set up such that it should call the callback function with a pass or fail.
This change would require we decouple calling the callback function and the authorization function (which is probably how things should've been set up in the first place).
Suggested changes:
For each authz file, remove callback, internalServerError, and unauthorized parameters and add a boolean return
Adjust the corresponding usage of auth.isAuthorized in the authn files to handle the boolean and end execution with a call to callback, internalServerError, or unauthorized
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
It seems that Google Groups authorization checks user membership in groups on every HTTP request. This is suboptimal. Should probably check only once before issuing
TOKEN
cookie. Then, in caseTOKEN
cookie is still valid, it should assume that user is authorized without checking group membership again.The text was updated successfully, but these errors were encountered: