Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recomended Reps = 0? #106

Closed
RhinoRSA opened this issue Oct 6, 2024 · 2 comments · Fixed by #98
Closed

Recomended Reps = 0? #106

RhinoRSA opened this issue Oct 6, 2024 · 2 comments · Fixed by #98

Comments

@RhinoRSA
Copy link

RhinoRSA commented Oct 6, 2024

Describe the bug

Algorith decreases reps below minimum.

To Reproduce

Steps to reproduce the behavior:

Start with 5 reps - 40 Weight - 3 RIR and just keep logging workouts decrease RIR obviously as the next week you will obviously increase intensity, this should result in the above mentioned case.

Expected behavior

Decrease Weight not Reps (As the expected rep range was 3-5) if difficulty is too high, 0 RIR should be considered failure, or decrease reps to minimum input, then decrease weight incrementally to either previous value or by percentage increased from previous workout until stability is reached where progression can start applying again.

Screenshots

image

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser Edge
  • Version 129.0.2792.79 (Official build) (64-bit)

Additional context

Trying to build out the following Program from Jeff Nippard - The Ultimate Push Pull Legs System 6X, but having quite some difficulty.
image

@WhyAsh5114
Copy link
Owner

Thanks for the issue submission!

I'm working on this right now, by replacing the current algorithm with a better one and setting the lower rep range as a hard limit and the higher one as a soft limit to prevent such issues from occurring. See more in #84.

Also thanks for giving the sample program, I'll add them as tests to prevent such issues from occurring in the future.

@RhinoRSA
Copy link
Author

RhinoRSA commented Oct 7, 2024

Thank You!

I might have another suggestion, Currently we can't set the number of sets individually when creating a program whereas on V2 we can, Would also be nice if we could set the starting weight (Side Note: have a check box labeled "warmup sets" then let us decide the qty of warmup sets and the app will divide our suggested/current starting weight into the 3 or 4 warmup sets and also automatically adjust the warmup weight per set as we progress ) so that when we finish a mesocycle, maybe take a week off/deload, we come back and can have a look at where we left off if we decide to run the same program again the previous training weight is either easily put in by the user or automatically populated.

@WhyAsh5114 WhyAsh5114 linked a pull request Oct 11, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants