-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some tests fail on arm32 #35
Comments
And more interesting is that on linux x86_64 under valgrind
|
And here is the output of
|
The previous test were done with my fork, here is the result for a fresh clone of this repo:
|
The
|
This seems to fix this test for both 64/32 bits:
|
Here is the output of
|
The
|
Now when compiled to 32bits it's failing with this test:
|
Here is the output of this project with my fixes on arm32 (adding this compiler option
|
This changes fix the
|
When building for 64bits on linux in release mode and executing
|
It seems that there is an |
On |
The problem seem to be here, when
|
Hello @WheretIB ! |
When running on armeabi-v7a Android device as well as on amr64-v8a, I do get some errors, but a bit different ones.
Overall, I recommend using nullc with
Looks like you have an older version of nullc, current test is for
Can't say why this one is failing, runs ok on my arm32 and arm64 Androids :(
Once again, the string test looks outdated. To check other failures, I'll need to setup an x86 linux emulator, I had one before and remember it working.
Thank you, that's a recent regression.
I'll add a clear there.
Interesting, Android.mk already uses -fsigned-char on Android for ARM and this tests complete without errors, so I don't know what's different here.
This is probably a better solution than using -fsigned-char, thank, I'll use it later.
Don't see any overflows locally when running with -fsanitize=address in x64 linux.
What's the problem?
Formatting that adds numbers to a string reserves enough space for the largest number. |
Your suggestion for signed/unsigned char fixes didn't work for me, I think additional fixes will be required. |
While testing this project on arm32 (android with termux clang9) I'm getting this errors:
The
strcmp
one is interesting because it return 6 on linux x86_64 when running throughnullc
but returns 1 when running through aC
test program:Output:
But
nullc
on arm32 return 1:The text was updated successfully, but these errors were encountered: