Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PackValidator, iOS AppStore domain #744

Open
thisIsTheFoxe opened this issue Feb 22, 2021 · 5 comments
Open

PackValidator, iOS AppStore domain #744

thisIsTheFoxe opened this issue Feb 22, 2021 · 5 comments

Comments

@thisIsTheFoxe
Copy link

private static final String APPLE_STORE_DOMAIN = "itunes.apple.com";

throw new IllegalStateException("iOS app store link should use app store domain: " + APPLE_STORE_DOMAIN);

Is there a specific reason it requires an itunes.apple.com domain? Afaik, the correct way to link an iOS app is via the apps.apple.com domain.
And yes, it is still working and will give you an HTTP/2 301 redirect to apps.apple.com. But then again, why use the redirect when you could just use the normal address right away?

@simonzhexu
Copy link
Contributor

Will fix.

@MarsVard
Copy link

To be fair, both domains should be accepted.

@simonzhexu
Copy link
Contributor

yep.

To be fair, both domains should be accepted.

@simonzhexu
Copy link
Contributor

simonzhexu commented Feb 26, 2021

I think we need to first fix WhatsApp to accept both domains, then after most clients upgrade, then change the domain on this repo, otherwise, WhatsApp will reject apps.apple.com

This process would probably take 3 months, in the meantime, I ask you bear with the incorrectness. Sorry.

@simonzhexu
Copy link
Contributor

I think the domain was itunes.apple.com, but then changed to apps.apple.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants