Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Error after trying to update a pack #599

Open
c42sx opened this issue Jan 29, 2020 · 30 comments
Open

[iOS] Error after trying to update a pack #599

c42sx opened this issue Jan 29, 2020 · 30 comments
Assignees
Labels
iOS iOS issue

Comments

@c42sx
Copy link

c42sx commented Jan 29, 2020

Some users are complaining that the packs are not being updated anymore, if the user sends a new version of the pack to the WhatsApp, WhatsApp saves as a new pack and does not ask to update the existing pack.
After the user saves the new version, the old version becomes some kind of ghost and the stickers disapears. If I try to access the old version, there is a eternal loading.
I verified the pack ID and it is always the same.
Here you can see the two versions of the same pack, the updated one with the stickers and the old one without stickers
https://imgur.com/awDcSbn
When I try to use the old version:
https://imgur.com/HBKhO4E

@aj8496
Copy link

aj8496 commented Feb 7, 2020

any update on this....

@c42sx
Copy link
Author

c42sx commented Feb 10, 2020

no update. Users keep sending emails complaining about this issue.

@Zandor300
Copy link
Contributor

@amrit-1901 Could you take a look at this? (cc @simonzhexu)

@aj8496
Copy link

aj8496 commented Feb 14, 2020

please give update on this Error...!

@simonzhexu
Copy link
Contributor

Sorry for the delay guys, looking.

@amrit-1901
Copy link
Contributor

amrit-1901 commented Feb 20, 2020

hmm, I can't reproduce this. @c42sx What do you have to change on the sticker pack to repro?

@c42sx
Copy link
Author

c42sx commented Feb 20, 2020

I dont need to do anything special, just add a pack as normal, then add a new sticker to the pack and try to add it again to WhatsApp, there will be no update button, the only option is save, like when you add a new pack.

@amrit-1901
Copy link
Contributor

Do you mind sending your app to me by email ([email protected])? I can't reproduce with my own project by doing the steps you mentioned, so maybe your app might give some more clues.

@markkorput
Copy link

markkorput commented Feb 24, 2020

  • iOS version: 13.3.1 (iPhone 7)
  • Whatsapp version: 2.19.124

When I try to update a previously added stickerpack on iOS, I don’t even get an option the save a new pack, like @c42sx, I only get the option to remove the existing stickerpack (big red Remove button). When confirming the remove action, the existing pack is removed but the update is NOT added.

So the UX for my app’s user is; save (in my app) —> confirm remove (in whatsapp) —> go back to original app —> save again (in my app) --> Confirm adding sticker pack (in whatsapp).

.............

(To reproduce; simply try it with the iOS example app)

@Zandor300
Copy link
Contributor

@amrit-1901 What is the workflow supposed to be? Should it just detect that the pack is different?

@c42sx
Copy link
Author

c42sx commented Feb 24, 2020

Do you mind sending your app to me by email ([email protected])? I can't reproduce with my own project by doing the steps you mentioned, so maybe your app might give some more clues.

already sent you the email. thanks

@amrit-1901
Copy link
Contributor

@c42sx Thanks, I'll take a look.
@Zandor300 Yeah, it should. The "Update" button should appear instead of the "Save" one

@aj8496
Copy link

aj8496 commented Feb 25, 2020

@c42sx Thanks, I'll take a look.
@Zandor300 Yeah, it should. The "Update" button should appear instead of the "Save" one

@amrit-1901 there is no update button is appearing, only save button is there for existing sticker pack

@amrit-1901
Copy link
Contributor

amrit-1901 commented Mar 2, 2020

ok, so I've taken a look at this and it seems that you are setting a different sticker pack id every time "Add to WhatsApp" is tapped. The sticker pack id should remain the same even if stickers are removed or deleted. I've used the "Sticker Maker" app to debug this btw.

@c42sx
Copy link
Author

c42sx commented Mar 2, 2020

ok, so I've taken a look at this and it seems that you are setting a different sticker pack id every time "Add to WhatsApp" is tapped. The sticker pack id should remain the same even if stickers are removed or deleted. I've used the "Sticker Maker" app to debug this btw.

I already double checked this, and did it again now that you mentioned it. We are sending the same pack id. I think the problem is WhatsApp because when we do send the pack again, the old pack appears as blank. If we were sending with a new pack id, both packs should appear with all the stickers. You can see the error in the old pack in this picture https://imgur.com/HBKhO4E . And it is really strange that a lot of stickers apps are having the same problem out of the blue.

@alexmorral
Copy link

alexmorral commented Mar 2, 2020

We are also experiencing this issue and we also think is WhatsApp's problem. We haven't updated our app in a relative long time and the issue suddenly appeared (maybe a WhatsApp update?). One of our users sent us this image.
EDIT: He tells us that when he tries to update the pack, the ghost one appears without the stickers, and a new one is created.

@amrit-1901
Copy link
Contributor

ok, yeah, it's actually our fault... sort of. It looks like iOS 13 is preventing us from using third party app bundle identifiers. The reason why I could't reproduce it is because I made my sticker app with the same team as the WhatsApp main app. This is actually a non-trivial problem to solve, but I'll keep you posted for any updates.

@c42sx
Copy link
Author

c42sx commented Apr 9, 2020

hi, any news about this issue?

@vOwl
Copy link

vOwl commented Jun 15, 2020

Hi,
Any news about it? @amrit-1901

@nikowiss
Copy link

Android has the sticker pack version number that allows packs to be updated inside WhatsApp. But WhatsApp on iOS seems to ignore the version number and adds instead a new pack (same identifier) which leaves the previously added pack as an empty "ghost pack".
I'd really like to have a solution for that.

@shayshtern
Copy link

shayshtern commented Jun 28, 2020

Anyone get to fix it? Same here on iPhone XS iOS 13.5.
I’m using Sticker Maker for iOS.

@gyeongnz
Copy link

Any news? Same here on Whatsapp version 2.21.30.20 for iOS
image

@BattleShipPark
Copy link

Do you have any updates?

@sofyafreyman
Copy link
Contributor

Hey guys, we are aware of this bug, it happens on iOS 13+ due to changes in API. I will prioritize finding a fix and will update you as soon as I can. Thanks for your patience

@alejoacostaa
Copy link

Any updates? As of today, this keeps happening.

@jluquer
Copy link

jluquer commented Dec 12, 2022

Still happening, any update?

@perpeer
Copy link

perpeer commented Mar 11, 2024

Any update ? It still is not working correctly.

@omerfarukozturk
Copy link

Hi @perpeer, could you share more details? such as;
Device, iOS version, Which app you're using to import (Sticker Maker?)
or also screen recording would be helpful.

@whiterose199187
Copy link

hello @omerfarukozturk

this problem still exists on iOS.

if you try to add stickers to an existing pack (same identifier, icon image). it creates an extra pack where 1 pack contains the images (earlier ones when pack was first created) and the second one is blank

Exactly as reported #599 (comment)

Is there any plan to address this?

The way I am exporting stickers is by creating a json as mentioned https://github.com/WhatsApp/stickers/tree/main/iOS#structure-of-the-json-file-that-is-sent-to-whatsapp

The goal is to add new stickers to an existing pack, how can this be done on iOS?

iphone 12, iOS 17.3.1
WhatsApp Version: 2.24.5.75

@whiterose199187
Copy link

following up on this again, are there any plans to address this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS iOS issue
Projects
None yet
Development

No branches or pull requests