Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read file only once #238

Open
awalterschulze opened this issue Jan 18, 2021 · 0 comments · May be fixed by #346
Open

Read file only once #238

awalterschulze opened this issue Jan 18, 2021 · 0 comments · May be fixed by #346
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@awalterschulze
Copy link
Contributor

#235 reads the file twice, but fixes an important issue to not write a file that has not been modified.

Possibly lets always read in the whole file as a string before sending it to the scanner, then it is available for comparison after formatting.

This should simplify a lot of the code and get rid of the file scanner.
@awalterschulze awalterschulze added the enhancement New feature or request label Jan 18, 2021
@awalterschulze awalterschulze mentioned this issue Jan 18, 2021
Merged
@awalterschulze awalterschulze added the help wanted Extra attention is needed label Mar 31, 2021
@jdamanalo jdamanalo linked a pull request Jan 12, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Read input only once jdamanalo/erlfmt
1 participant
@awalterschulze