Feat(#31): OpenweatherClient 기능 구현

Resolvers: #31

Author: KIMSEI1124

client/openweather-client/src/main/java/com/wypl/openweatherclient/OpenWeatherClient.java

@@ -1,66 +1,8 @@
 package com.wypl.openweatherclient;
 
-import org.springframework.boot.context.properties.EnableConfigurationProperties;
-import org.springframework.http.ResponseEntity;
-import org.springframework.stereotype.Component;
-import org.springframework.web.client.RestTemplate;
-
 import com.wypl.openweatherclient.data.OpenWeatherCond;
 import com.wypl.openweatherclient.data.OpenWeatherResponse;
-import com.wypl.openweatherclient.exception.OpenWeatherErrorCode;
-import com.wypl.openweatherclient.exception.OpenWeatherException;
-import com.wypl.openweatherclient.type.WeatherRegion;
-
-import lombok.RequiredArgsConstructor;
-
-@EnableConfigurationProperties(OpenWeatherProperties.class)
-@RequiredArgsConstructor
-@Component
-public class OpenWeatherClient {
-
-	private final RestTemplate restTemplate;
-	private final OpenWeatherProperties properties;
-
-	public OpenWeatherResponse fetchWeather(OpenWeatherCond cond) {
-		String url = getUrl(cond);
-		ResponseEntity<OpenWeatherResponse> response = restTemplate.getForEntity(
-				url,
-				OpenWeatherResponse.class
-		);
-		if (response.getStatusCode().is2xxSuccessful()) {
-			return response.getBody();
-		}
-		if (response.getStatusCode().is5xxServerError()) {
-			throw new OpenWeatherException(OpenWeatherErrorCode.INTERNAL_SERVER_ERROR);
-		}
-		throw new OpenWeatherException(OpenWeatherErrorCode.INVALID_OPEN_WEATHER_REQUEST);
-	}
-
-	private String getUrl(OpenWeatherCond cond) {
-		StringBuilder url = new StringBuilder(properties.getBaseUrl())
-				.append("?appid=")
-				.append(properties.getKey());
-
-		addParamByCity(url, cond.city());
-		addParamByLang(url, cond.isLangKr());
-		addParamByUnits(url, cond.isMetric());
-
-		return url.toString();
-	}
-
-	private void addParamByCity(StringBuilder url, WeatherRegion region) {
-		url.append("&q=").append(region.getCityEn());
-	}
-
-	private void addParamByLang(StringBuilder url, boolean isLangKr) {
-		if (isLangKr) {
-			url.append("&lang=kr");
-		}
-	}
 
-	private void addParamByUnits(StringBuilder url, boolean isMetric) {
-		if (isMetric) {
-			url.append("&units=metric");
-		}
-	}
+public interface OpenWeatherClient {
+	OpenWeatherResponse fetchWeather(OpenWeatherCond cond);
 }

client/openweather-client/src/main/java/com/wypl/openweatherclient/OpenWeatherClientImpl.java

@@ -0,0 +1,66 @@
+package com.wypl.openweatherclient;
+
+import org.springframework.boot.context.properties.EnableConfigurationProperties;
+import org.springframework.http.ResponseEntity;
+import org.springframework.stereotype.Component;
+import org.springframework.web.client.RestTemplate;
+
+import com.wypl.openweatherclient.data.OpenWeatherCond;
+import com.wypl.openweatherclient.data.OpenWeatherResponse;
+import com.wypl.openweatherclient.exception.OpenWeatherErrorCode;
+import com.wypl.openweatherclient.exception.OpenWeatherException;
+import com.wypl.openweatherclient.type.WeatherRegion;
+
+import lombok.RequiredArgsConstructor;
+
+@EnableConfigurationProperties(OpenWeatherProperties.class)
+@RequiredArgsConstructor
+@Component
+public class OpenWeatherClientImpl implements OpenWeatherClient {
+
+	private final RestTemplate restTemplate;
+	private final OpenWeatherProperties properties;
+
+	public OpenWeatherResponse fetchWeather(OpenWeatherCond cond) {
+		String url = getUrl(cond);
+		ResponseEntity<OpenWeatherResponse> response = restTemplate.getForEntity(
+				url,
+				OpenWeatherResponse.class
+		);
+		if (response.getStatusCode().is2xxSuccessful()) {
+			return response.getBody();
+		}
+		if (response.getStatusCode().is5xxServerError()) {
+			throw new OpenWeatherException(OpenWeatherErrorCode.INTERNAL_SERVER_ERROR);
+		}
+		throw new OpenWeatherException(OpenWeatherErrorCode.INVALID_OPEN_WEATHER_REQUEST);
+	}
+
+	private String getUrl(OpenWeatherCond cond) {
+		StringBuilder url = new StringBuilder(properties.getBaseUrl())
+				.append("?appid=")
+				.append(properties.getKey());
+
+		addParamByCity(url, cond.city());
+		addParamByLang(url, cond.isLangKr());
+		addParamByUnits(url, cond.isMetric());
+
+		return url.toString();
+	}
+
+	private void addParamByCity(StringBuilder url, WeatherRegion region) {
+		url.append("&q=").append(region.getCityEn());
+	}
+
+	private void addParamByLang(StringBuilder url, boolean isLangKr) {
+		if (isLangKr) {
+			url.append("&lang=kr");
+		}
+	}
+
+	private void addParamByUnits(StringBuilder url, boolean isMetric) {
+		if (isMetric) {
+			url.append("&units=metric");
+		}
+	}
+}

client/openweather-client/src/main/java/com/wypl/openweatherclient/exception/OpenWeatherErrorCode.java

@@ -7,8 +7,7 @@
 @Getter
 public enum OpenWeatherErrorCode implements ServerErrorCode {
 	INVALID_OPEN_WEATHER_REQUEST(500, "OPEN_WEATHER_001", "외부 서비스의 오류입니다."),
-	INTERNAL_SERVER_ERROR(400, "OPEN_WEATHER_002", "올바르지 않은 요청입니다."),
-	;
+	INTERNAL_SERVER_ERROR(400, "OPEN_WEATHER_002", "올바르지 않은 요청입니다.");
 
 	private final int statusCode;
 	private final String errorCode;

client/openweather-client/src/main/java/com/wypl/openweatherclient/type/WeatherType.java

@@ -23,8 +23,7 @@ public enum WeatherType {
 	MIST(6, new HashSet<>(List.of(701, 711, 721, 731, 741, 751, 761, 762)), "안개"),
 	SQUALL(7, new HashSet<>(List.of(771)), "스콜"),
 	TORNADO(8, new HashSet<>(List.of(781)), "태풍"),
-	THUNDERSTORM(9, new HashSet<>(List.of(200, 201, 202, 210, 211, 212, 221, 230, 231, 232)), "천둥"),
-	;
+	THUNDERSTORM(9, new HashSet<>(List.of(200, 201, 202, 210, 211, 212, 221, 230, 231, 232)), "천둥");
 
 	private final int weatherId;
 	private final Set<Integer> ids;