Rename(#41): Dto 클래스 이름 명확히 변경

Dto의 의도가 명확하지 않다는 피드백을 반영하여 아래와 같이 변경했습니다.
- MemberDto -> MemberSaveDto
- SocialMemberDto -> SocialMemberSaveDto

Author: sjhjack

application/wypl-core/src/main/java/com/wypl/wyplcore/auth/service/AuthServiceImpl.java

@@ -13,8 +13,8 @@
 import com.wypl.googleoauthclient.exception.GoogleOAuthErrorCode;
 import com.wypl.googleoauthclient.exception.GoogleOAuthException;
 import com.wypl.jpamemberdomain.member.OauthProvider;
-import com.wypl.jpamemberdomain.member.data.MemberDto;
-import com.wypl.jpamemberdomain.member.data.SocialMemberDto;
+import com.wypl.jpamemberdomain.member.data.MemberSaveDto;
+import com.wypl.jpamemberdomain.member.data.SocialMemberSaveDto;
 import com.wypl.jpamemberdomain.member.repository.MemberRepository;
 import com.wypl.jpamemberdomain.member.repository.SocialMemberRepository;
 import com.wypl.jpamemberdomain.member.utils.SocialMemberRepositoryUtils;
@@ -87,19 +87,19 @@ private long findMemberIdAfterSaveMember(String accessToken, GoogleUserInfoRespo
 		if (isNewMember(googleUserInfoResponse)) {
 			LocalDate birthday = googleOAuthClient.fetchBirthday(accessToken);
 
-			MemberDto memberDto = MemberDto.builder()
+			MemberSaveDto memberSaveDto = MemberSaveDto.builder()
 				.email(googleUserInfoResponse.email())
 				.birthday(birthday)
 				.nickname(googleUserInfoResponse.name())
 				.profileImage(googleUserInfoResponse.picture())
 				.build();
 
-			SocialMemberDto socialMemberDto = SocialMemberDto.builder()
+			SocialMemberSaveDto socialMemberSaveDto = SocialMemberSaveDto.builder()
 				.oauthProvider(OauthProvider.GOOGLE)
 				.oauthId(googleUserInfoResponse.id())
 				.build();
 
-			return authDomainService.saveAuthData(memberDto, socialMemberDto);
+			return authDomainService.saveAuthData(memberSaveDto, socialMemberSaveDto);
 		}
 
 		return SocialMemberRepositoryUtils.getSocialMember(socialMemberRepository, googleUserInfoResponse.id()).getId();

application/wypl-core/src/test/java/com/wypl/wyplcore/auth/service/AuthServiceImplTest.java

@@ -27,8 +27,8 @@
 import com.wypl.googleoauthclient.exception.GoogleOAuthErrorCode;
 import com.wypl.googleoauthclient.exception.GoogleOAuthException;
 import com.wypl.jpamemberdomain.member.OauthProvider;
-import com.wypl.jpamemberdomain.member.data.MemberDto;
-import com.wypl.jpamemberdomain.member.data.SocialMemberDto;
+import com.wypl.jpamemberdomain.member.data.MemberSaveDto;
+import com.wypl.jpamemberdomain.member.data.SocialMemberSaveDto;
 import com.wypl.jpamemberdomain.member.domain.SocialMember;
 import com.wypl.jpamemberdomain.member.repository.MemberRepository;
 import com.wypl.jpamemberdomain.member.repository.SocialMemberRepository;
@@ -117,7 +117,7 @@ void signUpTest() {
 			given(googleOAuthClient.fetchBirthday(anyString()))
 				.willReturn(LocalDate.now());
 
-			given(authDomainService.saveAuthData(any(MemberDto.class), any(SocialMemberDto.class)))
+			given(authDomainService.saveAuthData(any(MemberSaveDto.class), any(SocialMemberSaveDto.class)))
 				.willReturn(2L);
 
 			// When

domain/auth-domain/src/main/java/com/wypl/authdomain/auth/service/AuthDomainServiceImpl.java

@@ -3,8 +3,8 @@
 import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Transactional;
 
-import com.wypl.jpamemberdomain.member.data.MemberDto;
-import com.wypl.jpamemberdomain.member.data.SocialMemberDto;
+import com.wypl.jpamemberdomain.member.data.MemberSaveDto;
+import com.wypl.jpamemberdomain.member.data.SocialMemberSaveDto;
 import com.wypl.jpamemberdomain.member.domain.Member;
 import com.wypl.jpamemberdomain.member.domain.SocialMember;
 import com.wypl.jpamemberdomain.member.repository.MemberRepository;
@@ -22,9 +22,9 @@ public class AuthDomainServiceImpl {
 	private final TokenRepository tokenRepository;
 
 	@Transactional
-	public long saveAuthData(MemberDto memberDto, SocialMemberDto socialMemberDto) {
-		Member newMember = memberRepository.save(Member.of(memberDto));
-		SocialMember socialMember = socialMemberRepository.save(SocialMember.of(newMember, socialMemberDto));
+	public long saveAuthData(MemberSaveDto memberSaveDto, SocialMemberSaveDto socialMemberSaveDto) {
+		Member newMember = memberRepository.save(Member.of(memberSaveDto));
+		SocialMember socialMember = socialMemberRepository.save(SocialMember.of(newMember, socialMemberSaveDto));
 		return socialMember.getId();
 	}
 

domain/auth-domain/src/test/java/com/wypl/authdomain/auth/service/AuthDomainServiceImplTest.java

@@ -16,8 +16,8 @@
 
 import com.wypl.authdomain.auth.service.fixture.MemberFixture;
 import com.wypl.jpamemberdomain.member.OauthProvider;
-import com.wypl.jpamemberdomain.member.data.MemberDto;
-import com.wypl.jpamemberdomain.member.data.SocialMemberDto;
+import com.wypl.jpamemberdomain.member.data.MemberSaveDto;
+import com.wypl.jpamemberdomain.member.data.SocialMemberSaveDto;
 import com.wypl.jpamemberdomain.member.domain.Member;
 import com.wypl.jpamemberdomain.member.domain.SocialMember;
 import com.wypl.jpamemberdomain.member.repository.MemberRepository;
@@ -40,14 +40,14 @@ class AuthDomainServiceImplTest {
 	@EnumSource
 	void saveAuthDateTest(MemberFixture fixture) {
 		// Given
-		MemberDto memberDtoMock = MemberDto.builder()
+		MemberSaveDto memberSaveDtoMock = MemberSaveDto.builder()
 			.email("email")
 			.nickname("nickname")
 			.birthday(LocalDate.of(1999, 1, 15))
 			.profileImage("profileImage")
 			.build();
 
-		SocialMemberDto socialMemberDtoMock = SocialMemberDto.builder()
+		SocialMemberSaveDto socialMemberSaveDtoMock = SocialMemberSaveDto.builder()
 			.oauthProvider(OauthProvider.GOOGLE)
 			.oauthId("oauthId")
 			.build();
@@ -63,7 +63,7 @@ void saveAuthDateTest(MemberFixture fixture) {
 			.willReturn(socialMemberMock);
 
 		// When
-		long result = authDomainService.saveAuthData(memberDtoMock, socialMemberDtoMock);
+		long result = authDomainService.saveAuthData(memberSaveDtoMock, socialMemberSaveDtoMock);
 
 		// Then
 		assertThat(result).isEqualTo(socialMemberMock.getId());

domain/jpa-member-domain/src/main/java/com/wypl/jpamemberdomain/member/data/MemberDto.java domain/jpa-member-domain/src/main/java/com/wypl/jpamemberdomain/member/data/MemberSaveDto.java

@@ -7,7 +7,7 @@
 
 @Builder
 @Getter
-public class MemberDto {
+public class MemberSaveDto {
 	String email;
 	String nickname;
 	LocalDate birthday;

domain/jpa-member-domain/src/main/java/com/wypl/jpamemberdomain/member/data/SocialMemberDto.java domain/jpa-member-domain/src/main/java/com/wypl/jpamemberdomain/member/data/SocialMemberSaveDto.java

@@ -7,7 +7,7 @@
 
 @Getter
 @Builder
-public class SocialMemberDto {
+public class SocialMemberSaveDto {
 	OauthProvider oauthProvider;
 	String oauthId;
 }

domain/jpa-member-domain/src/main/java/com/wypl/jpamemberdomain/member/domain/Member.java

@@ -5,7 +5,7 @@
 import com.wypl.common.Color;
 import com.wypl.jpacommon.JpaBaseEntity;
 import com.wypl.jpamemberdomain.member.TimeZone;
-import com.wypl.jpamemberdomain.member.data.MemberDto;
+import com.wypl.jpamemberdomain.member.data.MemberSaveDto;
 
 import jakarta.persistence.Column;
 import jakarta.persistence.Entity;
@@ -57,12 +57,12 @@ public class Member extends JpaBaseEntity {
 //	@OneToMany(mappedBy = "member")
 //	private List<MemberCalendar> memberCalendars;
 
-	public static Member of(MemberDto memberDto) {
+	public static Member of(MemberSaveDto memberSaveDto) {
 		return Member.builder()
-			.email(memberDto.getEmail())
-			.nickname(memberDto.getNickname())
-			.birthday(memberDto.getBirthday())
-			.profileImage(memberDto.getProfileImage())
+			.email(memberSaveDto.getEmail())
+			.nickname(memberSaveDto.getNickname())
+			.birthday(memberSaveDto.getBirthday())
+			.profileImage(memberSaveDto.getProfileImage())
 			.color(Color.labelBrown)
 			.timeZone(TimeZone.KOREA)
 			.build();

domain/jpa-member-domain/src/main/java/com/wypl/jpamemberdomain/member/domain/SocialMember.java

@@ -1,7 +1,7 @@
 package com.wypl.jpamemberdomain.member.domain;
 
 import com.wypl.jpamemberdomain.member.OauthProvider;
-import com.wypl.jpamemberdomain.member.data.SocialMemberDto;
+import com.wypl.jpamemberdomain.member.data.SocialMemberSaveDto;
 
 import jakarta.persistence.Column;
 import jakarta.persistence.Entity;
@@ -42,11 +42,11 @@ public class SocialMember {
 	@Column(name = "oauth_id", nullable = false)
 	private String oauthId;
 
-	public static SocialMember of(Member member, SocialMemberDto socialMemberDto) {
+	public static SocialMember of(Member member, SocialMemberSaveDto socialMemberSaveDto) {
 		return SocialMember.builder()
 			.member(member)
-			.oauthProvider(socialMemberDto.getOauthProvider())
-			.oauthId(socialMemberDto.getOauthId())
+			.oauthProvider(socialMemberSaveDto.getOauthProvider())
+			.oauthId(socialMemberSaveDto.getOauthId())
 			.build();
 	}
 }

domain/jpa-member-domain/src/test/java/com/wypl/jpamemberdomain/MemberRepositoryTest.java

@@ -12,7 +12,7 @@
 import org.springframework.boot.test.autoconfigure.orm.jpa.DataJpaTest;
 import org.springframework.dao.DataIntegrityViolationException;
 
-import com.wypl.jpamemberdomain.member.data.MemberDto;
+import com.wypl.jpamemberdomain.member.data.MemberSaveDto;
 import com.wypl.jpamemberdomain.member.domain.Member;
 import com.wypl.jpamemberdomain.member.repository.MemberRepository;
 
@@ -24,19 +24,19 @@ public class MemberRepositoryTest {
 	@DisplayName("Member를 저장한다.")
 	@Nested
 	class memberSaveTest {
-		private MemberDto memberDtoMock;
+		private MemberSaveDto memberSaveDtoMock;
 		private Member member;
 
 		@BeforeEach
 		void beforeEach() {
-			memberDtoMock = MemberDto.builder()
+			memberSaveDtoMock = MemberSaveDto.builder()
 				.email("email")
 				.nickname("nickname")
 				.birthday(LocalDate.of(1999, 1, 15))
 				.profileImage("profileImage")
 				.build();
 
-			member = Member.of(memberDtoMock);
+			member = Member.of(memberSaveDtoMock);
 		}
 
 		@DisplayName("Member를 성공적으로 저장한다.")
@@ -48,17 +48,17 @@ void saveSuccessTest() {
 
 			// Then
 			assertThat(result.getMemberId()).isEqualTo(findMember.getMemberId());
-			assertThat(result.getEmail()).isEqualTo(memberDtoMock.getEmail());
-			assertThat(result.getNickname()).isEqualTo(memberDtoMock.getNickname());
-			assertThat(result.getBirthday()).isEqualTo(memberDtoMock.getBirthday());
-			assertThat(result.getProfileImage()).isEqualTo(memberDtoMock.getProfileImage());
+			assertThat(result.getEmail()).isEqualTo(memberSaveDtoMock.getEmail());
+			assertThat(result.getNickname()).isEqualTo(memberSaveDtoMock.getNickname());
+			assertThat(result.getBirthday()).isEqualTo(memberSaveDtoMock.getBirthday());
+			assertThat(result.getProfileImage()).isEqualTo(memberSaveDtoMock.getProfileImage());
 		}
 
 		@DisplayName("중복된 Member 저장에 실패한다.")
 		@Test
 		void duplicatedMemberSaveTest() {
 			// Given
-			Member duplicatedMember = Member.of(memberDtoMock);
+			Member duplicatedMember = Member.of(memberSaveDtoMock);
 
 			// When
 			memberRepository.save(member);

domain/jpa-member-domain/src/test/java/com/wypl/jpamemberdomain/SocialMemberRepositoryTest.java

@@ -13,8 +13,8 @@
 import org.springframework.dao.DuplicateKeyException;
 
 import com.wypl.jpamemberdomain.member.OauthProvider;
-import com.wypl.jpamemberdomain.member.data.MemberDto;
-import com.wypl.jpamemberdomain.member.data.SocialMemberDto;
+import com.wypl.jpamemberdomain.member.data.MemberSaveDto;
+import com.wypl.jpamemberdomain.member.data.SocialMemberSaveDto;
 import com.wypl.jpamemberdomain.member.domain.Member;
 import com.wypl.jpamemberdomain.member.domain.SocialMember;
 import com.wypl.jpamemberdomain.member.repository.SocialMemberRepository;
@@ -27,27 +27,27 @@ public class SocialMemberRepositoryTest {
 	@DisplayName("SocialMember를 저장한다.")
 	@Nested
 	class socialMemberSaveTest {
-		private SocialMemberDto socialMemberDtoMock;
+		private SocialMemberSaveDto socialMemberSaveDtoMock;
 		private Member member;
 		private SocialMember socialMember;
 
 		@BeforeEach
 		void beforeEach() {
-			MemberDto memberDtoMock = MemberDto.builder()
+			MemberSaveDto memberSaveDtoMock = MemberSaveDto.builder()
 				.email("email")
 				.nickname("nickname")
 				.birthday(LocalDate.of(1999, 1, 15))
 				.profileImage("profileImage")
 				.build();
 
-			socialMemberDtoMock = SocialMemberDto.builder()
+			socialMemberSaveDtoMock = SocialMemberSaveDto.builder()
 				.oauthProvider(OauthProvider.GOOGLE)
 				.oauthId("oauthId")
 				.build();
 
-			member = Member.of(memberDtoMock);
+			member = Member.of(memberSaveDtoMock);
 
-			socialMember = SocialMember.of(member, socialMemberDtoMock);
+			socialMember = SocialMember.of(member, socialMemberSaveDtoMock);
 		}
 
 		@DisplayName("SocialMember를 성공적으로 저장한다.")
@@ -65,7 +65,7 @@ void saveSuccessTest() {
 		@Test
 		void duplicatedMemberSaveTest() {
 			// Given
-			SocialMember duplicatedSocialMember = SocialMember.of(member, socialMemberDtoMock);
+			SocialMember duplicatedSocialMember = SocialMember.of(member, socialMemberSaveDtoMock);
 
 			// When
 			socialMemberRepository.save(socialMember);